Codex adapter split + hook enforcement port + output gating - #99
Merged
Conversation
The previous form piped through sed, which always exits 0, so the || echo "0.0.0" fallback never fires when git describe fails. Split into two lines so || binds to git describe's exit code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devkit-codexrepo; this branch keeps shared engine behavior here (98bddc3, 6fb14b4)required_outputsvalidation so steps can declare and the engine can gate on produced artifacts (c807c6f, abc7078)Tested in-session
test/hooks_test.sh), including the newinstall sets devkit MCP CLAUDE_PLUGIN_ROOTassertionworkflows/:CLAUDE_PLUGIN_ROOT:devkit_listcorrectly errors withno workflows directory: …CLAUDE_PLUGIN_ROOT(as emitted by the paired devkit-codex install.sh fix, commit6356c9a):devkit_listreturns all 22 workflowsv2.1.29-6-gabc7078Pairs with
6356c9a("Set devkit MCP plugin root") — emitsenv = { CLAUDE_PLUGIN_ROOT = … }in the[mcp_servers.devkit]block so the engine resolvesworkflows/against the devkit install, not the consumer cwd.Test plan (real Codex session, post-window-reset)
bash devkit-codex/install.sh --devkit /path/to/devkitagainst real~/.codex/config.tomlcodex mcp listshowsdevkithealthy in a fresh shellworkflows/) —devkit_listreturns 22 workflows/feature …slash command starts thefeatureworkflow via slash bridgetri-securityrm -rfmid-workflowinstall.sh --uninstallremoves only devkit-owned config/hooks, preserves any[mcp_servers.other]block