fix: stop polling when simulation fails#518
Open
cuixiao174 wants to merge 1 commit into666ghj:mainfrom
Open
Conversation
Previously, the frontend only checked for 'completed' and 'stopped' status to stop polling. When the simulation process exited with an error (runner_status === 'failed'), polling continued indefinitely. This commit adds handling for the 'failed' status: - Stop polling when runner_status is 'failed' - Display error message in the log - Update UI status to 'error' - Add i18n translations for simFailed key
dosubot
bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the frontend only checked for 'completed' and 'stopped' status to stop polling. When the simulation process exited with an error (runner_status === 'failed'), polling continued indefinitely.
This commit adds handling for the 'failed' status: