Add Rail 5 compatibility by ccallebs · Pull Request #11 · 85x14/griddler-ses

ccallebs · 2017-03-19T02:16:42Z

This is a PR to address #10.

Let me know if any changes are required.

Fix in case request_path is missing

apotapov · 2017-04-05T21:08:01Z

Any chance we can merge this in? Hitting this issue as well.

ccallebs · 2017-04-05T22:41:52Z

@apotapov I plan on supporting the gem if @85x14 doesn't respond. They don't have any public members.

ccallebs · 2017-04-05T22:42:27Z

@kmewhort Do you still have access to this repository?

apotapov · 2017-04-06T15:15:10Z

@ccallebs good stuff. Turns out that the emails we are receiving are often larger than 150kb which is the SES/SNS limit. So I'm going to have to process them through S3 instead of griddler.

If you do take over the development, might be worth reaching out to the folks at griddler to point to your repo instead of this one.

By the way I was seeing an error using the new sns_message.rb:

19:15:07 web.1    | NoMethodError - undefined method `unpack' for nil:NilClass:
19:15:07 web.1    |   /Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/2.3.0/base64.rb:59:in `decode64'
19:15:07 web.1    |    () Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/griddler-ses-3bc72638c800/lib/aws/sns_message.rb:115:in `decode'
19:15:07 web.1    |    () Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/griddler-ses-3bc72638c800/lib/aws/sns_message.rb:44:in `authentic?'
19:15:07 web.1    |    () Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/griddler-ses-3bc72638c800/lib/griddler/ses/adapter.rb:20:in `normalize_params'
19:15:07 web.1    |    () Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/griddler-ses-3bc72638c800/lib/griddler/ses/adapter.rb:15:in `normalize_params'
19:15:07 web.1    |   griddler (1.4.0) app/controllers/griddler/emails_controller.rb:17:in `normalized_params'
19:15:07 web.1    |   griddler (1.4.0) app/controllers/griddler/emails_controller.rb:3:in `create'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/abstract_controller/base.rb:188:in `process_action'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_controller/metal/rendering.rb:30:in `process_action'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/abstract_controller/callbacks.rb:20:in `block in process_action'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/callbacks.rb:126:in `call'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/callbacks.rb:506:in `block (2 levels) in compile'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/callbacks.rb:455:in `call'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/callbacks.rb:101:in `__run_callbacks__'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/callbacks.rb:750:in `_run_process_action_callbacks'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/callbacks.rb:90:in `run_callbacks'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/abstract_controller/callbacks.rb:19:in `process_action'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_controller/metal/rescue.rb:20:in `process_action'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/notifications.rb:164:in `block in instrument'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/notifications/instrumenter.rb:21:in `instrument'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/notifications.rb:164:in `instrument'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_controller/metal/instrumentation.rb:30:in `process_action'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_controller/metal/params_wrapper.rb:248:in `process_action'
19:15:07 web.1    |   activerecord (5.0.0.1) lib/active_record/railties/controller_runtime.rb:18:in `process_action'
19:15:07 web.1    |   sweet_notifications (1.0.0) lib/sweet_notifications/controller_runtime.rb:21:in `block (2 levels) in controller_runtime'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/abstract_controller/base.rb:126:in `process'
19:15:07 web.1    |   actionview (5.0.0.1) lib/action_view/rendering.rb:30:in `process'
19:15:07 web.1    |   rack-mini-profiler (0.10.1) lib/mini_profiler/profiling_methods.rb:102:in `block in profile_method'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_controller/metal.rb:190:in `dispatch'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_controller/metal.rb:262:in `dispatch'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:50:in `dispatch'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:32:in `serve'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/journey/router.rb:39:in `block in serve'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/journey/router.rb:26:in `serve'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:725:in `call'
19:15:07 web.1    |   rack-pjax (1.0.0) lib/rack/pjax.rb:12:in `call'
19:15:07 web.1    |   bullet (5.1.1) lib/bullet/rack.rb:12:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/deflater.rb:35:in `call'
19:15:07 web.1    |   remotipart (1.3.1) lib/remotipart/middleware.rb:32:in `call'
19:15:07 web.1    |   warden (1.2.6) lib/warden/manager.rb:35:in `block in call'
19:15:07 web.1    |   warden (1.2.6) lib/warden/manager.rb:34:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/etag.rb:25:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/conditional_get.rb:38:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/head.rb:12:in `call'
19:15:07 web.1    |    () Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/griddler-ses-3bc72638c800/lib/griddler/ses/middleware.rb:16:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/session/abstract/id.rb:222:in `context'
19:15:07 web.1    |   rack (2.0.1) lib/rack/session/abstract/id.rb:216:in `call'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/middleware/cookies.rb:613:in `call'
19:15:07 web.1    |   activerecord (5.0.0.1) lib/active_record/migration.rb:552:in `call'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/middleware/callbacks.rb:38:in `block in call'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/callbacks.rb:97:in `__run_callbacks__'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/callbacks.rb:750:in `_run_call_callbacks'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/callbacks.rb:90:in `run_callbacks'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/middleware/callbacks.rb:36:in `call'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/middleware/executor.rb:12:in `call'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/middleware/remote_ip.rb:79:in `call'
19:15:07 web.1    |   rollbar (2.12.0) lib/rollbar/middleware/rails/rollbar.rb:24:in `block in call'
19:15:07 web.1    |   rollbar (2.12.0) lib/rollbar.rb:735:in `scoped'
19:15:07 web.1    |   rollbar (2.12.0) lib/rollbar/middleware/rails/rollbar.rb:22:in `call'
19:15:07 web.1    |   better_errors (2.1.1) lib/better_errors/middleware.rb:84:in `protected_app_call'
19:15:07 web.1    |   better_errors (2.1.1) lib/better_errors/middleware.rb:79:in `better_errors_call'
19:15:07 web.1    |   better_errors (2.1.1) lib/better_errors/middleware.rb:57:in `call'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/middleware/debug_exceptions.rb:49:in `call'
19:15:07 web.1    |   rollbar (2.12.0) lib/rollbar/middleware/rails/show_exceptions.rb:22:in `call_with_rollbar'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
19:15:07 web.1    |   railties (5.0.0.1) lib/rails/rack/logger.rb:36:in `call_app'
19:15:07 web.1    |   railties (5.0.0.1) lib/rails/rack/logger.rb:24:in `block in call'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/tagged_logging.rb:70:in `block in tagged'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/tagged_logging.rb:26:in `tagged'
19:15:07 web.1    |   activesupport (5.0.0.1) lib/active_support/tagged_logging.rb:70:in `tagged'
19:15:07 web.1    |   railties (5.0.0.1) lib/rails/rack/logger.rb:24:in `call'
19:15:07 web.1    |   request_store (1.3.1) lib/request_store/middleware.rb:9:in `call'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/middleware/request_id.rb:24:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/method_override.rb:22:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/runtime.rb:22:in `call'
19:15:07 web.1    |   rack-timeout (0.4.2) lib/rack/timeout/core.rb:122:in `block in call'
19:15:07 web.1    |   rack-timeout (0.4.2) lib/rack/timeout/support/timeout.rb:19:in `timeout'
19:15:07 web.1    |   rack-timeout (0.4.2) lib/rack/timeout/core.rb:121:in `call'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/middleware/executor.rb:12:in `call'
19:15:07 web.1    |   actionpack (5.0.0.1) lib/action_dispatch/middleware/static.rb:136:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/sendfile.rb:111:in `call'
19:15:07 web.1    |   rack-cors (0.4.0) lib/rack/cors.rb:80:in `call'
19:15:07 web.1    |   rack-mini-profiler (0.10.1) lib/mini_profiler/profiler.rb:278:in `call'
19:15:07 web.1    |   railties (5.0.0.1) lib/rails/engine.rb:522:in `call'
19:15:07 web.1    |   puma (3.6.2) lib/puma/configuration.rb:225:in `call'
19:15:07 web.1    |   puma (3.6.2) lib/puma/server.rb:578:in `handle_request'
19:15:07 web.1    |   puma (3.6.2) lib/puma/server.rb:415:in `process_client'
19:15:07 web.1    |   puma (3.6.2) lib/puma/server.rb:275:in `block in run'
19:15:07 web.1    |   puma (3.6.2) lib/puma/thread_pool.rb:116:in `block in spawn_thread'
19:15:07 web.1    |

I'd rather not not share the payload here, but can send over if you like.

mort · 2017-04-18T10:52:27Z

Thanks a lot for this, @ccallebs

hadees · 2018-08-28T19:12:21Z

@ccallebs are you still going to maintain this?

ccallebs · 2018-08-28T19:20:11Z

@hadees Definitely willing to.

hadees · 2018-08-28T19:26:09Z

@ccallebs looks like you've already got a fork, can you just create a new gem? Then you can contact Griddler and have them link to you. You should also put up a tip thing because I'll be totally willing to buy you a 🍺 and help mantaining this.

I'm not sure @85x14 is ever coming back.

hadees · 2018-08-28T19:29:19Z

Actually @ccallebs I wonder if @85x14 is even a person. It looks like @kmewhort is the actual author.

ccallebs · 2018-08-28T19:34:59Z

@hadees Fair point, I can rename the gem. I'll do that this evening!

ccallebs · 2018-08-29T00:45:20Z

@hadees Would you want to code review the name change over at ccallebs#2?

* Fix test suite. * Rename from Griddler::Ses to Griddler::AmazonSES. * Update last references from Ses to AmazonSES. * Bump version to 2.0.0.

kmewhort · 2018-08-31T16:20:15Z

@ccallebs, just saw this thread after @hadees tagged me a couple days ago. We're not using this approach any more and I unfortunately don't really have the bandwidth to maintain it right now. I just added you as an admin to this repo if you'd want to do so here with the existing name - entirely up to you though!

ccallebs · 2018-09-01T01:39:04Z

Thanks @kmewhort! I think it's best to keep it here with the existing name. I'll work on merging the changes on my branch and bumping a major version number in process.

hughkolias · 2018-09-17T17:27:15Z

@ccallebs @kmewhort - updated the reference in Thoughtbot's README to the new forked version... thanks for the hard work!

…r#304) (#3)

ccallebs added 2 commits March 18, 2017 22:14

Import Aws::SnsMessage from ses_endpoint.

e1a3cdc

Update middleware declaration for Rails 5.

54c22ef

ccallebs changed the title ~~Replace sns_endpoint with extracted message class~~ Add Rail 5 compatibility Mar 19, 2017

rpfahl and others added 2 commits April 4, 2017 10:18

Fix in case request_path is missing

9e0c219

Merge pull request #1 from rpfahl/middleware_fix

7ffea9f

Fix in case request_path is missing

ccallebs and others added 4 commits August 29, 2018 16:59

Complete gem update from Griddler::Ses to Griddler::AmazonSES (#2)

d09e921

* Fix test suite. * Rename from Griddler::Ses to Griddler::AmazonSES. * Update last references from Ses to AmazonSES. * Bump version to 2.0.0.

Bump gemspec.

55157ae

Update gem version in Railtie.

952aa1f

Bump patch version.

ff7dce3

hughkolias and others added 2 commits September 17, 2018 21:07

Enforce UTF-8 encoding to fix the following issue (thoughtbot/griddle…

90bd18e

…r#304) (#3)

Bump version.

7669475

Conversation

ccallebs commented Mar 19, 2017

Uh oh!

apotapov commented Apr 5, 2017

Uh oh!

ccallebs commented Apr 5, 2017

Uh oh!

ccallebs commented Apr 5, 2017

Uh oh!

apotapov commented Apr 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mort commented Apr 18, 2017

Uh oh!

hadees commented Aug 28, 2018

Uh oh!

ccallebs commented Aug 28, 2018

Uh oh!

hadees commented Aug 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hadees commented Aug 28, 2018

Uh oh!

ccallebs commented Aug 28, 2018

Uh oh!

ccallebs commented Aug 29, 2018

Uh oh!

kmewhort commented Aug 31, 2018

Uh oh!

ccallebs commented Sep 1, 2018

Uh oh!

hughkolias commented Sep 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

apotapov commented Apr 6, 2017 •

edited

Loading

hadees commented Aug 28, 2018 •

edited

Loading