This repository was archived by the owner on Oct 22, 2025. It is now read-only.
Remove naive middleware check for a griddler path#8
Open
jdurand wants to merge 6 commits into85x14:masterfrom
Open
Remove naive middleware check for a griddler path#8jdurand wants to merge 6 commits into85x14:masterfrom
jdurand wants to merge 6 commits into85x14:masterfrom
Conversation
jdurand
commented
Oct 24, 2016
jdurand
commented
- Mounting Griddler is not a requirement: https://github.com/thoughtbot/griddler#installation
- The check didn't take domains/subdomains into account
- Checking for the HTTP_X_AMZ_SNS_MESSAGE_TYPE header is sufficient
- This actually breaks if Griddler is not mounted
1. Mounting Griddler is not a requirement: https://github.com/thoughtbot/griddler#installation 2. The check didn't take domains/subdomains into account 3. Checking for the HTTP_X_AMZ_SNS_MESSAGE_TYPE header is sufficient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.