chore(rpkg): re-scaffold via minirextendr; bump miniextendr pin to 3ab1ea9#194
Draft
CGMossa wants to merge 1 commit into
Draft
chore(rpkg): re-scaffold via minirextendr; bump miniextendr pin to 3ab1ea9#194CGMossa wants to merge 1 commit into
CGMossa wants to merge 1 commit into
Conversation
Contributor
Author
|
I am working on (yet again) an overhaul of how miniextendr packages are built. I needed to see how far off dvs-rpkg is right now.. This will be superseded soon. |
CGMossa
force-pushed
the
rescaffold/miniextendr-latest
branch
from
76982f3 to
fa38302
Compare
…b1ea9 Re-scaffolded `dvs-rpkg/` against the latest miniextendr (3ab1ea9) using `minirextendr::upgrade_miniextendr_package(configure_ac = TRUE)` and bumped the cargo git pin to match. Scaffolding changes: - bootstrap.R: produces inst/vendor.tar.xz via cargo-revendor for pkgbuild flows (devtools::build, r-lib/actions/check-r-package). - configure.ac: install-mode self-repair block, lock-shape-check, wasm32 detection (IS_WASM_INSTALL/CARGO_BUILD_STD_FLAG), drops obsolete `checksum =` strip (miniextendr#408 makes it a no-op / correctness regression on cargo >= 1.95). - src/Makevars.in: wasm32-conditional wrapper-gen, now also calls miniextendr_write_wasm_registry alongside miniextendr_write_wrappers. - src/rust/build.rs: wasm_registry.rs generator-version check. - inst/include/mx_abi.h: scoped clang 21+ -Wunknown-warning-option suppression (miniextendr#443). - New: src/r_shim.h, tools/lock-shape-check.R, src/rust/wasm_registry.rs (generated). Generated artifacts: - R/dvs-wrappers.R: tracks upstream rust_error_value → rust_condition_value rename and adds @export for ProgressBarCallback `$`/`[[` methods. - NAMESPACE / man/*.Rd: regenerated by devtools::document(). Verification: configure clean, R CMD INSTALL clean, devtools::test() PASS 123/0/0, clippy -D warnings clean. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
CGMossa
force-pushed
the
rescaffold/miniextendr-latest
branch
from
fa38302 to
b4bfa72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-scaffolds
dvs-rpkg/againstminiextendr@3ab1ea9viaminirextendr::upgrade_miniextendr_package(configure_ac = TRUE), and bumps the cargo git pin to match. This is the project rule in action: never cherry-pick miniextendr fixes into the rpkg by hand — bump the pin upstream-first, then re-scaffold. Pulls in install-mode self-repair, the lockfile-shape-drift check, wasm32 detection, the newbootstrap.Rvendoring story, and the scoped clang 21+ warning fix inmx_abi.h. Drops the now-obsoletechecksum =strip inconfigure.ac(regression on cargo ≥ 1.95;miniextendr#408made it a no-op). Wrapper / NAMESPACE regen tracks upstream'srust_error_value→rust_condition_valuerename and the newProgressBarCallbackS3 method export.AI-written details
Scaffolding files touched
bootstrap.R,configure.ac, regeneratedconfiguresrc/Makevars.in,src/rust/build.rs,inst/include/mx_abi.hsrc/r_shim.h,tools/lock-shape-check.R,src/rust/wasm_registry.rs(auto-generated)Test plan
just rpkg-configureclean, source-mode detected, lock-shape-check passesjust rpkg-installclean, R wrappers regeneratedjust rpkg-documentclean, NAMESPACE andman/*.Rdupdateddevtools::test('dvs-rpkg')PASS, 0 fail / 0 warn / 0 skipjust rpkg-clippy -- -D warningscleanjust rpkg-testcargo tests +tests/rv(local-path install) PASSNotes
#[derive(DataFrameRow)](miniextendr#485) could simplify the hand-rolledFileStatusView/FileMetadataViewserde mirror structs indvs-rpkg/src/rust/lib.rs:356-418and their post-hoc column rename/drop chain, applied inside dvs-rpkg only so the coredvscrate stays miniextendr-free. Would need miniextendr-side views that wrapdvs::status::FileStatus/StatusDetail/GetDetailrather than deriving directly on core types.Drafted by Claude (claude-opus-4-7). Reviewed by the author.