feat(rpkg): expose --recursive in dvs_get#204
Open
CGMossa wants to merge 1 commit into
Open
Conversation
This was referenced May 16, 2026
R-binding layer of `dvs get --recursive`. Carved out of #154; depends on feat/dvs-get-recursive-core (which holds the core globbing change and the CLI flag). - src/rust/lib.rs: `dvs_get` gains `recursive: Option<bool>` (default NULL) wired through to `resolve_paths_for_get`. - src/rust/Cargo.toml: pin `dvs` to the core branch until the core PR lands on main. Re-pin to main before final review. - R/dvs-commands.R: thin pass-through to `dvs_get_impl`. - man/dvs_get*.Rd: regenerated. Includes the clarifying paragraph explaining the recursive flag only constrains descendants of paths passed explicitly — empty `paths` returns every tracked file regardless. - man/dvs_status*.Rd: same clarifying paragraph applied to `dvs_status(recursive=)` for symmetry (the existing one-line description was ambiguous on the same edge case). - tests/testthat/test-get.R: covers the new flag. NB: builds standalone against the companion core PR's branch pin.
CGMossa
force-pushed
the
feat/dvs-get-recursive-core
branch
from
64dd1e1 to
d340c2b
Compare
CGMossa
force-pushed
the
feat/dvs-rpkg-get-recursive
branch
from
d034deb to
5456863
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-written details
Summary
R-binding layer of
dvs get --recursive. Carved out of #154 as part of a 3-way split. Stacked on #203 (core+CLI), which holds the actual globbing change and the-rflag.src/rust/lib.rs:dvs_getgainsrecursive: Option<bool>(defaultNULL) wired through toresolve_paths_for_get.src/rust/Cargo.toml: dvs git pin switched frombranch = "main"tobranch = "feat/dvs-get-recursive-core"so this PR builds standalone before the core lands. Re-pin to main before final merge.R/dvs-commands.R: thin pass-through todvs_get_impl.man/dvs_get*.Rd: regenerated. Includes the clarifying paragraph explaining the recursive flag only constrains descendants of paths passed explicitly — emptypathsreturns every tracked file regardless.man/dvs_status*.Rd: same clarifying paragraph applied todvs_status(recursive=)for symmetry (the existing one-line description was ambiguous on the same edge case).tests/testthat/test-get.R: covers the new flag.Test plan
just rpkg-installcleanjust rpkg-documentproduces no diffjust rpkg-testpassesdvs_get(recursive = TRUE)walks the directory recursively in a smoke sessionSequencing
main.main, revert the Cargo.tomlbranch =tomain, push.Follow-up
ui/main_recursive.shexercising the matrix → separate PR.Drafted by Claude (claude-opus-4-7). Reviewed by the author.