Skip to content

Replace deprecated Models usage with Generators #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amanichab wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace deprecated Models usage with Generators #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee9fa03
Update benchmark_assignment.py
Amanichab Jun 27, 2025
3be1f54
Update README.md
Amanichab Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ An example of how to specify such models is provided in the snippet below:
```python
...
GenerationStep(
model=Models.BOTORCH_MODULAR,
model=Generators.BOTORCH_MODULAR,
num_trials=-1,
max_parallelism=3,
model_kwargs={"botorch_acqf_class": qKnowledgeGradient},
Expand Down
12 changes: 6 additions & 6 deletions benchmark_assignment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@

import numpy as np
from ax.service.ax_client import AxClient, ObjectiveProperties
from ax.modelbridge.factory import Models
from ax.modelbridge.generation_strategy import GenerationStep, GenerationStrategy
from ax.modelbridge.factory import Generators
from ax.generation_strategy.generation_strategy import GenerationStep, GenerationStrategy
from botorch.acquisition import ExpectedImprovement

seed_list = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
Expand All @@ -42,8 +42,8 @@
# --------------------------------------------------------------------------------------
import numpy as np
from ax.service.ax_client import AxClient, ObjectiveProperties
from ax.modelbridge.factory import Models
from ax.modelbridge.generation_strategy import GenerationStep, GenerationStrategy
from ax.modelbridge.factory import Generators
from ax.generation_strategy.generation_strategy import GenerationStep, GenerationStrategy
from botorch.acquisition import UpperConfidenceBound

seed_list = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
Expand Down Expand Up @@ -81,8 +81,8 @@

import numpy as np
from ax.service.ax_client import AxClient, ObjectiveProperties
from ax.modelbridge.factory import Models
from ax.modelbridge.generation_strategy import GenerationStep, GenerationStrategy
from ax.modelbridge.factory import Generators
from ax.generation_strategy.generation_strategy import GenerationStep, GenerationStrategy
from botorch.acquisition import LogExpectedImprovement

seed_list = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
Expand Down