Skip to content

add MISMIP test config#17

Open
justinh2002 wants to merge 44 commits intomainfrom
justinh2002/configuration
Open

add MISMIP test config#17
justinh2002 wants to merge 44 commits intomainfrom
justinh2002/configuration

Conversation

@justinh2002
Copy link
Collaborator

@justinh2002 justinh2002 commented Jul 22, 2025


🚀 The latest prerelease access-issm/pr17-12 at d3a5e1f is here: #17 (comment) 🚀

justinh2002 and others added 30 commits April 16, 2025 13:36
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@gmail.com>
@lawrenceabird
Copy link
Collaborator

@justinh2002 -- The mismip_driver.py needs a Domain.exp file to build the mesh. This file will need to be added to this example. I suggest moving things from test/mismip/ to examples/mismip/ and adding examples/mismip/files/ to contain relevant files (e.g. Domain.exp and move Mismip.py here).

@ACCESS-NRI ACCESS-NRI deleted a comment from github-actions bot Oct 15, 2025
@ACCESS-NRI ACCESS-NRI deleted a comment from github-actions bot Oct 15, 2025
@ACCESS-NRI ACCESS-NRI deleted a comment from github-actions bot Oct 15, 2025
@ACCESS-NRI ACCESS-NRI deleted a comment from github-actions bot Oct 15, 2025
@justinh2002
Copy link
Collaborator Author

@justinh2002 -- The mismip_driver.py needs a Domain.exp file to build the mesh. This file will need to be added to this example. I suggest moving things from test/mismip/ to examples/mismip/ and adding examples/mismip/files/ to contain relevant files (e.g. Domain.exp and move Mismip.py here).

im going to keep them all in the same directory for now, so it retains the same structure as examples in upstream ISSM

@github-actions
Copy link

🚀 Attempted to deploy access-issm Prerelease pr17-9 with commit 8038cd4

🖥️ Gadi Deployment ❌

@github-actions
Copy link

🚀 Attempted to deploy access-issm Prerelease pr17-6 with commit 6c0863a

🖥️ Gadi Deployment ✔️

Usage Instructions

access-issm, defined in ./spack.yaml, will be deployed to Gadi as:

  • 2025.06.0 as a Release (when merged).
  • pr17-6 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-issm/pr17-6

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-issm-pr17-6 environment.
Due to inode-saving measures, one will have to manually untar the environment metadata before environment activation with tar -xf .spack-env .spack-env.tar. It will require one to have write privileges.

Configuration Information

This Prerelease is deployed using:

If the above was not what was expected, commit changes to config/versions.json in this PR.

@github-actions
Copy link

🚀 Attempted to deploy access-issm Prerelease pr17-10 with commit 6d21289

🖥️ Gadi Deployment ❌

@justinh2002
Copy link
Collaborator Author

!redeploy

@github-actions
Copy link

🚀 Attempted to deploy access-issm Prerelease pr17-11 with commit 6d21289

🖥️ Gadi Deployment ✔️

Usage Instructions

access-issm, defined in ./spack.yaml, will be deployed to Gadi as:

  • 2025.06.0 as a Release (when merged).
  • pr17-11 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-issm/pr17-11

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-issm-pr17-11 environment.
Due to inode-saving measures, one will have to manually untar the environment metadata before environment activation with tar -xf .spack-env .spack-env.tar. It will require one to have write privileges.

Configuration Information

This Prerelease is deployed using:

If the above was not what was expected, commit changes to config/versions.json in this PR.

@lawrenceabird
Copy link
Collaborator

Hey @justinh2002 -- I've managed to get to step 2 of the mismip_driver.py. I'm stalled now as we also need the ./Front.exp argus file.

Can you please add this file and any other additional files that are needed?

@github-actions
Copy link

🚀 Attempted to deploy access-issm Prerelease pr17-13 with commit 0f24c57

🖥️ Gadi Deployment ❌

@github-actions
Copy link

🚀 Attempted to deploy access-issm Prerelease pr17-12 with commit d3a5e1f

🖥️ Gadi Deployment ❌

@CodeGat
Copy link
Member

CodeGat commented Oct 16, 2025

You're really testing the concurrent deployment corner case here @justinh2002, thanks 😆

@lawrenceabird
Copy link
Collaborator

lawrenceabird commented Oct 16, 2025

Hey @justinh2002 -- I was thinking about this and I'm actually not sure that we need the run_pps.sh or run_mismip_first.sh scripts. Both of these just point to the Mismip_driver.py. The first couple of steps (building the mesh and parameterising the model) are really small, so that can be completed without submitting a PBS job. Then, all transient simulation steps should automatically submit a PBS job via a cluster, right? So we could maybe just refactor this into a single script for users? They can pass things like the steps to run, a project code and execution path that can be used to populate the cluster information? What do you think?

@justinh2002
Copy link
Collaborator Author

Hey @justinh2002 -- I was thinking about this and I'm actually not sure that we need the run_pps.sh or run_mismip_first.sh scripts. Both of these just point to the Mismip_driver.py. The first couple of steps (building the mesh and parameterising the model) are really small, so that can be completed without submitting a PBS job. Then, all transient simulation steps should automatically submit a PBS job via a cluster, right? So we could maybe just refactor this into a single script for users? They can pass things like the steps to run, a project code and execution path that can be used to populate the cluster information? What do you think?

Could you point me to your tweaks in your separate branch so I can cherry-pick and then refactor them all into one script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants