Closed
Conversation
Collaborator
|
Thanks for this PR @dkhutch! Unfortunately our CI doesn't run from forks (security) so I've cherry-picked your change into a branch in this repo and opened a new PR with the same change here: #74 Next time we can give you write access so you can submit your PR from a branch on this repo - just open an issue if you have any other proposed changes. I'll close this PR now and move over to #74 |
Author
|
Thanks Dougie. Ok, next time I'll see if I can do it without making a fork. I might need to ask some follow-up basic questions though, because I'm not very familiar with github pull requests. |
Collaborator
|
All good. And to be clear, the approach you took of making a fork is the most common way. We're just a bit cautious because our CI submits things to Gadi. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to AVX vectorization flags for compiling on NeSI.