Open
Conversation
CodeGat
added
type:bug
priority:medium
for:v8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #363
Background
We can't get the url or ref information for the
umspack package because it doesn't have agitattribute in thepackage.py. It has special variants and data within the file for that purpose.The PR
get_packages_metadata()function to get theumdata specially - as in, it gets the URL from the_resource_cfgattribute at https://github.com/ACCESS-NRI/access-spack-packages/blob/38fec2deecd505a244ea47416eb1def01e4b0aa2/spack_repo/access/nri/packages/um/package.py#L183; and it's version from the value of theum_refvariant at https://github.com/ACCESS-NRI/access-spack-packages/blob/38fec2deecd505a244ea47416eb1def01e4b0aa2/spack_repo/access/nri/packages/um/package.py#L78Testing
Tested via ACCESS-NRI/ACCESS-AM3#30