Checkout actual spack-config ref supplied, update references to new upstream-spack-packages repository#390
Merged
Merged
Conversation
…mplating, update all references from spack/spack-packages to access-nri/upstream-spack-packages
CodeGat
added
type:bug
priority:blocker
for:v8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See failing workflow https://github.com/ACCESS-NRI/ACCESS-OM2/actions/runs/26136102887/job/76871574166?pr=148
Background
The above workflow actually demonstrates two bugs:
Bug 1: Using a non-existent step output
In
deploy-1-setup.ymlsCheckout spack-config to get builtin spack-packages refstep, we mistakenly templateactions/checkoutsrefwithsteps.config-settings-refs.outputs.spack-config(which doesn't exist - should besteps.config-settings-refs.outputs.spack-config-ref). This means that it has been using the currentmainofspack-configfor validation of configuration, rather than the version that the spack instance is currently using.Due to a recent change (ACCESS-NRI/spack-config#113) to
spack-config, it led to us attempting to validate aACCESS-NRI/upstream-spack-packagesbranch against thespack/spack-packagesrepository. Which leads to the second bug...Bug 2: Not updating references to
upstream-spack-packagesWe have moved to
ACCESS-NRI/upstream-spack-packages. But the CI is still validating against the originalspack/spack-packages. Even if the first bug hadn't happened, this would show up when we updated the spack instancesspack-configto the currentmain.The PR
spack-configref, rather thanmain, by using the proper template variablespack/spack-packagestoACCESS-NRI/upstream-spack-packages.