Skip to content

Create an issue when repro-ci result is error & assign target branch in test-repro#206

Open
Qian-HuiChen wants to merge 2 commits intomainfrom
fix-error-raising
Open

Create an issue when repro-ci result is error & assign target branch in test-repro#206
Qian-HuiChen wants to merge 2 commits intomainfrom
fix-error-raising

Conversation

@Qian-HuiChen
Copy link
Contributor

Major fix:
Previously, automated issues were only created when the repro-ci result was labeled as failure. This PR updates the logic to also trigger issue creation when the result is error.

Minor fix:
Updated test-repro to explicitly assign the correct target branch when triggered via a GitHub comment. This is to avoid fallback to the main branch.

Copy link
Contributor

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this in! The changes to reduce duplication in creating the issue for error/failure look good.

As the scheduled tests are used to run more than just repro checks now (it runs QA tests for some branches), does it make sense to change wording from Reproducibility/Repro Scheduled tests to just Scheduled tests in the issue? Feel free to leave as is though!

Comment on lines +114 to +115
Test summary:
${{ steps.variables.outputs.icon }} ${{ needs.repro-ci.outputs.summary}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably good to put details of what tests were run at the bottom of the issue, and they probably won't need need the icon as they already have icons as part of the text. E.g.

Test summary:
 ${{ needs.repro-ci.outputs.summary}}

If config tests are configured, there can be quite a number of tests run so could put the test summary into a dropdown section? E.g.

<details>
<summary>Test Summary</summary>

${{ needs.repro-ci.outputs.summary}}
</details>

Config Repo: `${{ steps.variables.outputs.config }}`, found here: ${{ steps.variables.outputs.config-url }}
Config Ref Tested for Reproducibility: `${{ inputs.config-ref }}`, found here: ${{ steps.variables.outputs.ref-url }}
Failed Run Log: ${{ steps.variables.outputs.run-url }}
${{ steps.variables.outputs.log_label }}: ${{ steps.variables.outputs.run-url }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
${{ steps.variables.outputs.log_label }}: ${{ steps.variables.outputs.run-url }}
Github Run Log: ${{ steps.variables.outputs.run-url }}

Could generalise the name here?

- name: Setup Issue Variables
id: variables
run: |
if [[ "${{ needs.repro-ci.outputs.result }}" == "error" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could swap the if-else blocks here, e.g.

if [[ "${{ needs.repro-ci.outputs.result }}" == "failure" ]]
# When the tests run successfully and failed
else
# When there was an error running tests ( either "${{ needs.repro-ci.outputs.result }}" == "error" or failure())

Copy link
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the comments Jo made, this looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants