Add geospatial extent to model ouput schema#67
Add geospatial extent to model ouput schema#67joshuatorrance wants to merge 10 commits into66-clone-of-schemafrom
Conversation
aidanheerdegen
left a comment
aidanheerdegen
left a comment
There was a problem hiding this comment.
Questions and suggestions ...
|
|
||
| - name: Install the Sourcemeta JSON Schema CLI | ||
| uses: sourcemeta/jsonschema@v11.8.3 | ||
| uses: sourcemeta/jsonschema@v14.14.2 |
There was a problem hiding this comment.
| uses: sourcemeta/jsonschema@v14.14.2 | |
| uses: sourcemeta/jsonschema@f0b6672d82955e58a73efd320068284a4e7a4483 #v14.14.2 |
To reduce the possibility of supply-chain injection attacks we use commit hashes rather than versions for all actions not owned by us or GitHub.
| # Need to iterate through each pair of DIRS since there will be name | ||
| # collisions with different versions of the same schema |
There was a problem hiding this comment.
Do you need to specify --resolve on the command line if target is defined in the test file?
| "examples": [ 90, 12.98 ], | ||
| "type": "number", | ||
| "maximum": 90, | ||
| "minimum": -90 |
There was a problem hiding this comment.
I know it's difficult to say a-priori what the minimum of lat_max should be, but -90 seems kinda odd.
Also, it should be greater than lat_min, but can we refer to other attributes in that way? Or is that more of a manual check we should make with CI in a data publishing pipeline?
| "description": "Specifies the southernmost latitude covered by the dataset. Units should be \"degrees North\" and values should be a number equal to or between -90 and 90.", | ||
| "examples": [ -90, -57.97 ], | ||
| "type": "number", | ||
| "maximum": 90, |
There was a problem hiding this comment.
See other comment, +90 seems odd for lat_min but I understand there might not be much else that can be done.
There was a problem hiding this comment.
Should there be (failing) tests where require fields are missing and/or have incorrect values?
2 participants
Closes #66
Adds the follow attributes to the model output schema:
Details and description are heavily
plagiarisedinspired by the ACDD equivalents.I restricted this schema to require units of
degrees_north/degrees_east. ACDD permits other units.I have also restricted the longitude to -180 to 180. ACDD also allows 0 to 360. Reasoning here is just to keep things simple, if this would be restrictive then it can be relaxed.
number. These are the firstnumbersin the schema - need to check all the downstream tools handle numbers correctly.addmetaneeds a solution for numerical templates see issue & PRaccess-output-data-specificationsmay need an update to the auto-doc generation