Open
Conversation
2 tasks
| "const": "time_bnds" | ||
| }, | ||
| "calendar": { | ||
| "const": "proleptic_gregorian" |
Member
There was a problem hiding this comment.
The repeat year forcing ocean configurations use NO_LEAP
https://github.com/ACCESS-NRI/access-om3-configs/blob/dev-MC_25km_jra_ryf/nuopc.runconfig#L263
(Both OM2 and OM3).
Comment on lines
+24
to
+29
| "description": "Units for time should be given as \"days since X\" where X is a date (yyyy-mm-dd) or a datetime (yyyy-mm-dd HH:MM or yyyy-mm-dd HH:MM:SS)", | ||
| "examples": [ | ||
| "days since 0001-01-01 00:00:00", | ||
| "days since 0001-01-01 00:00", | ||
| "days since 1970-01-01", | ||
| "days since -5000-12-25" |
Member
There was a problem hiding this comment.
Are we sure it is always days, even for sub-daily fields?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
timeandtime_bndsto the schema.The current proposal requires the bounds to be name
time_bnds. If this is relaxed to allowtime_boundsthen some further updates will be required. Could just use a regex to allow the alternative but this might permit a mix of the two. Compelling them to match will require additional some extra chicanery.Contributes to #68
Closes #69