Conversation
jo-basevi
left a comment
There was a problem hiding this comment.
Looks great to me! Just a couple insignificant questions - so feel free to resolve
|
@jo-basevi I also forgot to add a job for a version sanity check. Would you mind having a look at the PR now in its final state? |
34296e4 to
29cbca9
Compare
jo-basevi
left a comment
There was a problem hiding this comment.
Looks good to me - no major comments.
I wonder if it would be useful using the semver command line tool, or similar, for parsing and comparing versions? Could have logic checking if a tag equals one of semver --increment "major" "$new_tag_name" or semver --increment "minor" "$new_tag_name", etc. I think (?) semver $new_tag_name only returns zero if it's a valid version too.
29cbca9 to
00fb6dd
Compare
…release. Added cleanup step for release tags
194d528 to
814ad68
Compare
ce133c8 to
96e502e
Compare
jo-basevi
left a comment
There was a problem hiding this comment.
Overall I think the changes looks good to me. I just have another small comment
jo-basevi
left a comment
There was a problem hiding this comment.
Thanks @atteggiani, looks good to me!
|
Thank you @jo-basevi for reviewing! |
Added resources for
condapackaging.The
umfile_utilspackage will be released to the accessnri anaconda channel and will be installable with:This PR includes CI/CD framework to automatically verify, build and upload the
umfile_utilspackage.