Open
Conversation
jnh277
reviewed
Feb 27, 2026
Collaborator
jnh277
left a comment
jnh277
left a comment
There was a problem hiding this comment.
Awesome you are contributing this fix
nemdata/mmsdm.py
Outdated
| csv_name = f"PUBLIC_DVD_{table.table}_{year}{padded_month}010000.CSV" | ||
| if (year, month) >= (2024, 8): | ||
| # PREDISP_ALL_DATA and P5MIN_ALL_DATA have a different naming convention with #ALL before #FILE01 | ||
| if table.directory.endswith("_ALL_DATA"): |
Collaborator
There was a problem hiding this comment.
I believe this could be simplified to
url = f"{url_prefix}/{table.directory}/PUBLIC_ARCHIVE#{table.table}#{year}{padded_month}010000.zip"
url = url.replace("#", "%23")
# name of the CSV that comes out of the zipfile
csv_name = f"PUBLIC_ARCHIVE#{table.table}#{year}{padded_month}010000.CSV"
and then the else case could be
url = f"{url_prefix}/{table.directory}/PUBLIC_DVD_{table.legacy_table}_{year}{padded_month}010000.zip"
# name of the CSV that comes out of the zipfile
csv_name = f"PUBLIC_DVD_{table.legacy_table}_{year}{padded_month}010000.CSV"
Author
|
is this what you mean @jnh277 |
jnh277
reviewed
Feb 28, 2026
| MMSDMTable( | ||
| name="p5min", | ||
| table="P5MIN_REGIONSOLUTION_ALL", | ||
| table="P5MIN_REGIONSOLUTION#ALL#FILE01", |
Collaborator
There was a problem hiding this comment.
What's the use case for the #ALL#FILE01 Is aemo storing some additional versions of files?
Author
There was a problem hiding this comment.
i think for the larger constraint files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates MMSDM filenames to correct format where relevant. Added check for unexpected multiple files. File structure remains the same.
Background / Context
Since August 24, MMSDM filenames have changed.
For fun, they've changed differently in the predispatch and data directories.
Seems to be to account for multiple files uploaded per table.
Changes
e.g.
"DATA" directory
https://nemweb.com.au/Data_Archive/Wholesale_Electricity/MMSDM/2024/MMSDM_2024_08/MMSDM_Historical_Data_SQLLoader/DATA/PUBLIC_ARCHIVE%23DISPATCHPRICE%23FILE01%23202408010000.zip
"PREDISP_ALL_DATA" directory
https://nemweb.com.au/Data_Archive/Wholesale_Electricity/MMSDM/2024/MMSDM_2024_08/MMSDM_Historical_Data_SQLLoader/PREDISP_ALL_DATA/PUBLIC_ARCHIVE%23PREDISPATCHPRICE%23ALL%23FILE01%23202408010000.zip
i.e.
"DATA" directory
f"PUBLIC_ARCHIVE#{table.table}#FILE01#{year}{padded_month}010000.CSV"
"PREDISP_ALL_DATA" directory
f"PUBLIC_ARCHIVE#{table.table}#ALL#FILE01#{year}{padded_month}010000.CSV"
Testing
added tests for 2025 data, all passed