Skip to content

fix: resolve 4 critical bugs in GeoVisionAI#1

Open
ADITYA-CODE-SOURCE wants to merge 1 commit intomainfrom
fix/bugs-gsoc2026
Open

fix: resolve 4 critical bugs in GeoVisionAI#1
ADITYA-CODE-SOURCE wants to merge 1 commit intomainfrom
fix/bugs-gsoc2026

Conversation

@ADITYA-CODE-SOURCE
Copy link
Copy Markdown
Owner

Summary

This PR fixes 4 critical bugs identified in the GeoVisionAI codebase:

Bug Fixes

  1. Bug: Null Reference in home.mjs - queries svg but uses img LiquidGalaxyLAB/LG-GeoVisionAI#90: Null Reference in home.mjs

    • Changed querySelector svg to img since the template uses img not svg
    • Added null check for safety
  2. Bug: Missing slot in voice.mjs component LiquidGalaxyLAB/LG-GeoVisionAI#91: Missing slot in voice.mjs

    • Added slot name voice to the shadow DOM template
    • This allows the voice animation elements from index.html to render properly
  3. Bug: Regex quantifier error in voice.mjs location pattern matching LiquidGalaxyLAB/LG-GeoVisionAI#92: Regex quantifier error

    • Fixed: send me to+ to send me to with proper whitespace matching
    • The + was outside the group, matching send me toooo instead of send me to
    • Also added missing whitespace to fly to pattern for consistency
  4. Bug: CSS scroll-behavior conflict in style.css LiquidGalaxyLAB/LG-GeoVisionAI#94: CSS scroll-behavior conflict

    • Changed body scroll-behavior auto to smooth
    • This matches the html element and enables proper smooth scrolling

Files Changed

  • js/components/home.mjs
  • js/components/voice.mjs
  • css/style.css

GSoC 2026 contribution

Fixed bugs:
- LiquidGalaxyLAB#90: Fix null reference in home.mjs (querySelector 'svg' -> 'img')
- LiquidGalaxyLAB#91: Add missing slot in voice.mjs component
- LiquidGalaxyLAB#92: Fix regex quantifier error in location pattern matching
- LiquidGalaxyLAB#94: Fix CSS scroll-behavior conflict in style.css

GSoC 2026 contribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant