Reconstruct more fluxes when using excised transmitting poles#146
Draft
Reconstruct more fluxes when using excised transmitting poles#146
Conversation
…cautious timesteps
… Potentially less wrong?
…le but maybe too many B_CT::UtoP.
The Kastaun inverter is guaranteed to converge with only a tiny minimum of limits. This commit restricts the implementation to apply only these. Without internal floors, results can be very unstable, especially for the case that no velocity will satisfy the momentum; for this, the inverter reconstructs the maximum possible velocity. Thus we apply an adapted form of Normal Observer floors after inversion, which are guaranteed to add at least enough material and energy to satisfy constraints. We also check that the new primitives have the correct momentum -- if not, the velocity is zeroed to avoid myriad problems evolving high speeds. Most of the momentum in these cells comes from B, not rho, so I think this is a reasonable choice in practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was (is) an alternative method for calculating the fluxes in the cells around an exised pole. In perfunctory testing it did not produce less polar "wake" in tilted simulations, vs the excision fluxes that are in
dev.Leaving it here as a draft in case someone running tilted disks wants to play with it.