Fix language picker current label#42
Merged
Merged
Conversation
JimmFly
reviewed
May 26, 2026
Contributor
JimmFly
left a comment
There was a problem hiding this comment.
No blocking findings from my static review. The regional language resolution is scoped to the picker binding, keeps the stored language behavior intact, and the new unit test imports the correct OpenBridge module. Public CI checks are green; I did not run a local macOS build from this broker session.
cuesurfbot
approved these changes
May 26, 2026
Contributor
cuesurfbot
left a comment
There was a problem hiding this comment.
独立静态 review。
- 新的
macos/OpenBridgeUnitTests/Suites/AppLanguageSelectionTests.swift使用@testable import OpenBridge,与同目录其他测试一致;该 repo 单一macos/OpenBridge.xcodeproj,module 名即OpenBridge,没有 cueboard 那种 Bridge / Cueboard 名字漂移。 AppLanguageSelection与 cueboard PR #2056 的实现完全等价;regional / empty / unsupported / available filter 四条单元测试足以覆盖核心 resolve 逻辑。AppearanceSettingsView/GeneralSettingsView中languageSelectionbinding 的 getter 把 stored value 解析到 Picker 选项,setter 直接写回settingsManager.language,仅在用户主动选择时触发,原Locale.preferredLanguages.first默认值(regional)行为不会被悄悄重写。- Public CI(Web / Sandbox VM Go Tests / Repository Hygiene)全部绿色。
执行情况:未在本地跑 macOS build;该 repo 不在 Public CI 中跑 macOS。没有 blocking issue。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation