Skip to content

Fix language picker current label#42

Merged
JimmFly merged 1 commit into
mainfrom
codex/language-picker-current-label
May 26, 2026
Merged

Fix language picker current label#42
JimmFly merged 1 commit into
mainfrom
codex/language-picker-current-label

Conversation

@zzj3720
Copy link
Copy Markdown
Contributor

@zzj3720 zzj3720 commented May 26, 2026

Summary

  • Resolve stored regional/default language identifiers to supported app localization picker options
  • Bind General/Appearance language pickers to that resolved selection so the current label is visible before switching
  • Add regression tests for regional and empty/default language values

Validation

  • git hook: swiftformat + swiftlint passed
  • manual helper check: zh-Hans-CN -> zh-Hans, en-US -> en, empty preferred zh-Hans-CN -> zh-Hans
  • app build / GUI smoke pending

Copy link
Copy Markdown
Contributor

@JimmFly JimmFly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings from my static review. The regional language resolution is scoped to the picker binding, keeps the stored language behavior intact, and the new unit test imports the correct OpenBridge module. Public CI checks are green; I did not run a local macOS build from this broker session.

@JimmFly JimmFly marked this pull request as ready for review May 26, 2026 10:49
Copy link
Copy Markdown
Contributor

@cuesurfbot cuesurfbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

独立静态 review。

  • 新的 macos/OpenBridgeUnitTests/Suites/AppLanguageSelectionTests.swift 使用 @testable import OpenBridge,与同目录其他测试一致;该 repo 单一 macos/OpenBridge.xcodeproj,module 名即 OpenBridge,没有 cueboard 那种 Bridge / Cueboard 名字漂移。
  • AppLanguageSelection 与 cueboard PR #2056 的实现完全等价;regional / empty / unsupported / available filter 四条单元测试足以覆盖核心 resolve 逻辑。
  • AppearanceSettingsView / GeneralSettingsViewlanguageSelection binding 的 getter 把 stored value 解析到 Picker 选项,setter 直接写回 settingsManager.language,仅在用户主动选择时触发,原 Locale.preferredLanguages.first 默认值(regional)行为不会被悄悄重写。
  • Public CI(Web / Sandbox VM Go Tests / Repository Hygiene)全部绿色。

执行情况:未在本地跑 macOS build;该 repo 不在 Public CI 中跑 macOS。没有 blocking issue。

@JimmFly JimmFly merged commit a9ca905 into main May 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants