fix: use Harness theme aliases in dark mode - #12
Open
haotian-lu-prog wants to merge 2 commits into
Open
Conversation
Owner
Owner
|
Maybe we need to add @deepseek-ai/dsh-client-ui-theme to devDependencies, I'll fix it |
AHGGG
marked this pull request as ready for review
August 15, 2026 16:05
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
--dsw-*variables as fallbacks for compatibility with older hostsWhy
In DeepSeek Harness dark mode, the plugin's selection toolbar and other Side Chat surfaces could render with their light fallback backgrounds while inheriting the host's light foreground color. This produced white or near-white text on a white surface and made the controls unreadable.
The current Harness theme publishes colors through semantic aliases such as
--dsw-alias-bg-layer-2,--dsw-alias-label-primary, and--dsw-alias-border-l2. Using those aliases keeps the plugin synchronized with both light and dark palettes without hard-coding a separate dark theme.User impact
The Side Chat panel, selected-text action toolbar, annotation editor, message bubbles, and interactive states now remain readable in both light and dark appearance modes.
Validation
npm run typechecknpm run lintnpm run test(76 tests)npm_config_cache=/private/tmp/dsh-side-chat-npm-cache npm run pack:verifyrgb(44, 44, 46)surface /rgb(249, 250, 251)text (13.34:1 contrast)rgb(255, 255, 255)surface /rgb(15, 17, 21)text