Conversation
…ross-project dispatch Email delivery to external branches (e.g. @strategy in Vera-Studio) worked because delivery.py already had a caller-registry fallback, but wake failed with "Branch not found" because resolve_branch() only checked AIPASS_REGISTRY. Extracted the shared registry-walking logic into registry/read.py::get_caller_project_branches(), then: - wake.py resolve_branch() now checks AIPASS_REGISTRY first, then falls back to the caller's project registry via AIPASS_CALLER_CWD (cross-project wake) - delivery.py _load_caller_project_branches() delegates to the shared function (eliminates duplicate implementation) Fixes #283. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #283.
When an external project (e.g. Vera-Studio) called
drone @ai_mail dispatch @strategy "msg" "body", email delivery worked (delivery.py already had a caller-registry fallback viaAIPASS_CALLER_CWD) but wake failed withBranch not found: @strategybecauseresolve_branch()in wake.py only checkedAIPASS_REGISTRY.json.Root cause
wake.py::resolve_branch()had no fallback to the caller's project registry.delivery.py::_load_caller_project_branches()had the full implementation but it was private and duplicated.Fix
get_caller_project_branches(caller_cwd)inapps/handlers/registry/read.pywake.py::resolve_branch()to check the AIPass registry first, then fall back to the caller's project registry viaAIPASS_CALLER_CWD(same env var delivery.py already uses)delivery.py::_load_caller_project_branches()to delegate to the shared function, eliminating the duplicate implementation.seedgo/bypass.jsonwith correct entries for all new cross-handler imports and nestingTest plan
TestGetCallerProjectBranches(7 new tests in test_registry_read.py): covers list format, dict format, relative path resolution, parent-directory walking, empty resultTestResolveBranchCallerRegistry(3 new tests in test_wake.py): covers cross-project fallback, AIPass-registry-takes-precedence, not-found-anywhere🤖 Generated with Claude Code