feat(api+spawn): DPLAN-0133 Phase 1 (part 2/2) + Phase 2 — bridge registry, driver auto-discovery, integrations handlers

[AIOSAI]

Summary

Phase 1 (part 2/2) — spawn template scaffold

• Adds apps/integrations/README.md to the builder template so every branch spawned with drone @spawn create automatically gets the private integration scaffold introduced in DPLAN-0133.
• Template registry regenerated: 44 → 45 files, 23 → 24 directories.
• New test in test_citizen_classes.py asserts apps/integrations/README.md exists after _spawn_agent().

Phase 2 — @api driver registry + generic contract system

• bridge.py — module-level dict registry (register/resolve/list_contracts/clear); zero side-effects on import
• registry.py — load_drivers() walks apps/integrations/*/driver.py via importlib; handles empty dirs, missing driver.py, and broken imports gracefully (logs WARNING, skips, no crash); idempotent via _loaded flag
• integrations_manager.py — auto-discovered module routing drone @api integrations list and drone @api integrations call <contract> [args...]
• handlers/integrations/list.py + call.py — thin handler layer (log + return result dicts)
• apps/integrations/testcontract/driver.py — canary driver (gitignored); registers "test" → "pong"
• tests/test_integrations.py — 17 new tests (bridge CRUD, registry walk, fetch_contracts, call_contract)

Test plan

• drone @api integrations list with empty apps/integrations/ → "No integrations configured", exit 0
• drone @api integrations list on this branch → shows test (canary driver)
• drone @api integrations call test → prints pong, exit 0
• drone @api integrations call nope → error message, exit 1
• python -m pytest src/aipass/api/tests/ — 306 existing + 17 new = 323 passed, zero regressions
• python -m pytest src/aipass/spawn/tests/ — 215 passed, 37 skipped

Do not merge — user reviewing end of day.

🤖 Generated with Claude Code

[AIOSAI]

PR overlap map (all three PRs touch overlapping files via drone @git system-pr backlog scoop):

• PR feat(drone): fix merge_plugin: stash unstaged changes before git pull --rebase to prevent dirty-tree abort #288 (drone, merge_plugin stash/pop fix) — 1 file, self-contained
• PR feat(system): DPLAN-0133 Phase 1 (part 1/2): add gitignore rule for apps/integrations/** with README negation, plus scaffold README.md in all 10 core branches' apps/integrations/ — private integration space is now leak-proof by construction. Drivers and wrappers dropped here stay local; only README.md is tracked. See DPLAN-0133 for architecture rationale (three-layer design: @api drivers, per-branch wrappers, public generic contracts). #289 (devpulse, DPLAN-0133 Phase 1 part 1/2) — 12 files = [.gitignore + 10 branch READMEs + STATUS.md] + scoops merge_plugin.py from feat(drone): fix merge_plugin: stash unstaged changes before git pull --rebase to prevent dirty-tree abort #288
• PR feat(api+spawn): DPLAN-0133 Phase 1 (part 2/2) + Phase 2 — bridge registry, driver auto-discovery, integrations handlers #290 (spawn, DPLAN-0133 Phase 1 part 2/2) — 17 files = everything in feat(system): DPLAN-0133 Phase 1 (part 1/2): add gitignore rule for apps/integrations/** with README negation, plus scaffold README.md in all 10 core branches' apps/integrations/ — private integration space is now leak-proof by construction. Drivers and wrappers dropped here stay local; only README.md is tracked. See DPLAN-0133 for architecture rationale (three-layer design: @api drivers, per-branch wrappers, public generic contracts). #289 + [builder template scaffold + registry + test + bypass] + scoops merge_plugin.py from feat(drone): fix merge_plugin: stash unstaged changes before git pull --rebase to prevent dirty-tree abort #288

PR #290 is a strict superset of both #288 and #289. Merging #290 alone delivers all three sets of changes. Recommended merge strategy: close #288 and #289 as superseded by #290, then merge #290. OR merge in order #288 → #289 → #290 and accept that each will be partially redundant on top of the prior.

No conflicts between the three — they all modify the same content to the same end state. Pure backlog scoop artifact. — devpulse

[AIOSAI]

@api just pushed Phase 2 onto this branch. PR #290 is now the complete DPLAN-0133 Phase 1 + Phase 2 delivery (+1411 -9).

Full PR #290 contents:

• drone's merge_plugin stash/pop fix (scooped from feat(drone): fix merge_plugin: stash unstaged changes before git pull --rebase to prevent dirty-tree abort #288)
• Phase 1 pt 1: repo-root gitignore rule + 10 branch README scaffolds (from feat(system): DPLAN-0133 Phase 1 (part 1/2): add gitignore rule for apps/integrations/** with README negation, plus scaffold README.md in all 10 core branches' apps/integrations/ — private integration space is now leak-proof by construction. Drivers and wrappers dropped here stay local; only README.md is tracked. See DPLAN-0133 for architecture rationale (three-layer design: @api drivers, per-branch wrappers, public generic contracts). #289)
• Phase 1 pt 2: spawn builder template integration + test + registry update
• Phase 2 (new): @api/apps/modules/bridge.py (registry), registry.py (auto-discovery walker), integrations_manager.py (module-layer routing), handlers/integrations/{list,call}.py, 17 new tests (TestBridge ×5, TestRegistry ×6, TestFetchContracts ×2, TestCallContract ×4), canary testcontract driver
• 323/323 tests green

Acceptance per @api's reply:

• drone @api integrations list (empty) → 'No integrations configured.', exit 0 ✓
• drone @api integrations list (this branch) → shows 'test' ✓
• drone @api integrations call test → 'pong', exit 0 ✓
• drone @api integrations call nope → error + exit 1 ✓

One design note from @api: handlers can't import bridge directly per seedgo's cli/handlers rule, so they went with module-layer orchestration — integrations_manager.py calls bridge and passes data to handlers. Public API surface is fetch_contracts() and call_contract() on integrations_manager.

Merge strategy: PR #290 is now the strict superset of #288 and #289 AND Phase 2. Merging #290 alone delivers everything. Close #288 and #289 as superseded. — devpulse

[AIOSAI]

Stress test complete — 2 bugs found and fixed (pushed to this branch)

Tested with 4 test drivers: multi-contract (memory/search/explode), broken import, no register() hook, empty folder.

Bug 1 (fixed, commit 5ab2a99): drone @api integrations foobar exited 0 instead of 1 — unknown subcommands weren't calling sys.exit(1). Now exits non-zero properly.

Bug 2 (fixed, same commit): Error message showed 'Try: Try: list, call' — doubled prefix because error() already adds '→ Try:' and the suggestion string also started with 'Try:'. Removed the duplicate from the suggestion.

What passed clean (no bugs):

• Multi-contract driver registering 3 contracts from one driver.py ✓
• Args forwarding through bridge to driver functions ✓
• Complex return types (strings, dicts) printed correctly ✓
• Driver that raises RuntimeError — caught cleanly, error message shown, exit 1 ✓
• Broken driver (import error) — skipped by registry walker, logged warning, other drivers loaded fine ✓
• Driver without register() hook — loaded without crash ✓
• Empty folder (no driver.py) — skipped silently ✓
• All test drivers correctly gitignored by the repo-root rule ✓
• 17/17 @api tests pass after fix

Verdict: Phase 2 is solid. Two minor bugs in error handling, now fixed. Core architecture (bridge registry, auto-discovery, contract dispatch) works correctly under stress. — devpulse