Add missing entity smaccers#34
Open
Doma-0609 wants to merge 6 commits intoAIPTU:masterfrom
Open
Conversation
Poggit-CI is enabled for this repo by @Doma-0609 Visit the Poggit-CI page for this repo at https://poggit.pmmp.io/ci/Doma-0609/Smaccer
Poggit-CI is enabled for this repo by @Doma-0609 Visit the Poggit-CI page for this repo at https://poggit.pmmp.io/ci/Doma-0609/Smaccer
Reviewer's GuideRegisters six new smaccer NPC entity types (ArmorStand, CamelHusk, CopperGolem, ElderGuardianGhost, HappyGhast, ZombiePigman) in SmaccerHandler and implements their corresponding entity classes with size, name, and network type bindings. Class diagram for newly added Smaccer NPC entities and handler mappingsclassDiagram
class SmaccerHandler {
- array npcs
}
class EntitySmaccer
class EntityAgeable
class ArmorStandSmaccer {
+ getInitialSizeInfo() EntitySizeInfo
+ getHeight() float
+ getWidth() float
+ getNetworkTypeId() string
+ getName() string
}
class CamelHuskSmaccer {
+ getInitialSizeInfo() EntitySizeInfo
+ getHeight() float
+ getWidth() float
+ getNetworkTypeId() string
+ getName() string
+ getBabyScale() float
}
class CopperGolemSmaccer {
+ getInitialSizeInfo() EntitySizeInfo
+ getHeight() float
+ getWidth() float
+ getNetworkTypeId() string
+ getName() string
}
class ElderGuardianGhostSmaccer {
+ getInitialSizeInfo() EntitySizeInfo
+ getHeight() float
+ getWidth() float
+ getNetworkTypeId() string
+ getName() string
}
class HappyGhastSmaccer {
+ getInitialSizeInfo() EntitySizeInfo
+ getHeight() float
+ getWidth() float
+ getNetworkTypeId() string
+ getName() string
}
class ZombiePigmanSmaccer {
+ getInitialSizeInfo() EntitySizeInfo
+ getHeight() float
+ getWidth() float
+ getNetworkTypeId() string
+ getName() string
+ getBabyScale() float
}
EntitySmaccer <|-- ArmorStandSmaccer
EntitySmaccer <|-- CopperGolemSmaccer
EntitySmaccer <|-- ElderGuardianGhostSmaccer
EntitySmaccer <|-- HappyGhastSmaccer
EntityAgeable <|-- CamelHuskSmaccer
EntityAgeable <|-- ZombiePigmanSmaccer
SmaccerHandler ..> ArmorStandSmaccer : registers
SmaccerHandler ..> CamelHuskSmaccer : registers
SmaccerHandler ..> CopperGolemSmaccer : registers
SmaccerHandler ..> ElderGuardianGhostSmaccer : registers
SmaccerHandler ..> HappyGhastSmaccer : registers
SmaccerHandler ..> ZombiePigmanSmaccer : registers
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added smaccer entities:
Summary by Sourcery
Add support for additional smaccer NPC entity types and register them in the central handler.
New Features: