Fix: Adjust DPI Scaling and Visibility Issues for Screen Captures#1
Open
TheNevix wants to merge 3 commits intoAKouki:masterfrom
Open
Fix: Adjust DPI Scaling and Visibility Issues for Screen Captures#1TheNevix wants to merge 3 commits intoAKouki:masterfrom
TheNevix wants to merge 3 commits intoAKouki:masterfrom
Conversation
…ion which was offset. Fixed the selection and opacity to not be saved when selecting a region.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses several issues encountered with screen capture functionality in the SCapture project. Here's a breakdown of the changes and their benefits:
Fixes Implemented:
DPI Scaling Adjustment: Implemented DPI scaling adjustments for the full screen capture method. This ensures that screen captures are accurate on high-DPI displays, fixing previous issues where captures were not correctly scaled to the system's DPI settings.
Selection Visibility: Modified the region capture workflow to hide the selection rectangle. Also fixed the opacity which was not being set to normal after selecting a region. This resolves the issue where the selection rectangle was visible and that the screen is not darker because of the opacity.
Capture Region Accuracy: Refined the calculation of the capture region to ensure the selected area corresponds exactly to the user's intention, particularly addressing offsets that appeared in the captured images.
Consistent Area Selection: Ensure consistent selection area in region selections.