fix(dashboard): require loopback Host and JSON Content-Type on control plane - #11
Open
SashaMIT wants to merge 1 commit into
Open
fix(dashboard): require loopback Host and JSON Content-Type on control plane#11SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
…l plane The dashboard is an unauthenticated loopback control plane. Without a Host allowlist, a DNS-rebinding page that reaches the TCP port can still call the API with application/json. Without a JSON Content-Type gate on every POST, cross-origin text/plain forms can inject instructions, resolve approvals, or switch the browsed run. Cap POST bodies and cover both gates with unit tests.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hostheader is not loopback (or the configured bind host). A DNS-rebinding page that reaches the TCP port withHost: evil.examplecan no longer read/api/stateor drive the agent.application/json(optionalcharset=…ok) for/api/inject,/api/approvals/.../resolve, and/api/select-run. Cross-origintext/plainform posts become preflighted, which this server never answers.tests/test_dashboard_server.pycovering both gates.This supersedes #6 (Content-Type only on two routes; no Host check; claimed charset/
select-runcoverage was incomplete).Test plan
PYTHONPATH=src python3 -m unittest tests.test_dashboard_server -v(11 tests)Host: evil.example+Content-Type: application/jsoninject/resolve → 403; loopback Host + JSON → 200;text/plainon inject/select-run → 415Made with Cursor