ROCM 7.2 and RDNA support#14
Open
Spacefish wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a real pull request, as the code is not production quality / it makes it incompatible with wave64 cards.
But this branch let´s you build it against ROCM 7.2 and works on RNDA consumer cards aka 32 wide waves instead of 64.
Downside: It adapts the original algorithm but needs to use Shared Memory now to combine the results of two warps when processing 8x8 blocks, as we no longer have the perfect 64 pixels to 64 warps match ..
Just opened it so if someone stumples upon the same problem, it already works :)
using it in nerfstudio with splatfacto and it works. This is from my gfx1101 (Navi 32 based rdna 3 card named 7800 XT):
