Update checkout command to use release branch#15
Open
sagerkudrick wants to merge 1 commit into
Open
Conversation
install_dependencies.sh exists in the release/1.5.3b2 branch not main
Author
|
Just following up on this PR. The instructions differ between main and release/1.5.3b2, so I aligned the README with the release branch behavior. Let me know if the intended target should instead be updated to match main, happy to adjust |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install_dependencies.sh exists in the release/1.5.3b2 branch not main
Motivation
install_dependencies.sh doesn't exist in main, theirs has requirements.txt and requires the user to pip install -r requirements.txt rather than executing this script. ROCm install differs from the modern NVIDIA install
Furthermore, release/1.5.3b2's main/examples is 552 commits ahead of main
Technical Details
Test Plan
Test Result
./install_dependencies.sh fails because the file doesn't exist.
If you instead use pip install -r requirements.txt that main assumes, you get an incorrect installation as release/1.5.3b2 includes:
pip install git+https://github.com/rahul-goel/fused-ssim/@88169c51c22973ad8fd2429c3298d8356fdd5dc8 --no-build-isolation
Submission Checklist