Skip to content

fix(code): trust Hub host for code-server links#166

Merged
MioYuuIH merged 5 commits into
developfrom
fix/code-server-trusted-domains
Jul 9, 2026
Merged

fix(code): trust Hub host for code-server links#166
MioYuuIH merged 5 commits into
developfrom
fix/code-server-trusted-domains

Conversation

@MioYuuIH

@MioYuuIH MioYuuIH commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Automatically derive the current public Hub host and inject it as a code-server trusted domain for Back-to-Hub links.
  • Add optional custom.codeServer.extraTrustedDomains values for deployment-specific trusted sites without hardcoding platform domains.
  • Translate trusted domains into code-server --link-protection-trusted-domains flags and document the runtime contract.

Verification

  • python3 -m pytest runtime/hub/tests/test_git_clone_persistence.py runtime/hub/tests/test_config_resource_metadata.py
  • bash -n dockerfiles/Code/start-code-server.sh
  • python3 scripts/generate_values_schema.py

@MioYuuIH MioYuuIH requested a review from KerwinTsaiii as a code owner July 8, 2026 05:56
@MioYuuIH MioYuuIH merged commit ae5614f into develop Jul 9, 2026
16 checks passed
@MioYuuIH MioYuuIH deleted the fix/code-server-trusted-domains branch July 9, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant