Fix authorization issues with mock resources#883
Merged
jonathan-r-thorpe merged 12 commits intomasterfrom Oct 15, 2025
Merged
Conversation
* Allow CORS for Auth server * Use correct scopes for registration and query APIs of Registry * Relax enforced use of optional Auth features
Contributor
Author
|
Checked for regressions against nmos-cpp on Windows/Ubuntu with authorization enabled/disabled. |
lo-simon
suggested changes
Aug 8, 2025
Contributor
lo-simon
left a comment
There was a problem hiding this comment.
Just a couple of minor suggestions, rest LGTM.
Co-authored-by: Simon Lo <simon.lo@sony.com>
lo-simon
approved these changes
Aug 8, 2025
cristian-recoseanu
approved these changes
Sep 3, 2025
Contributor
cristian-recoseanu
left a comment
There was a problem hiding this comment.
Seems reasonable, however, I do not have an environment where I can test this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After doing some controller testing of nmos-js using authorization the following issues were identified:
The following fixes were introduced: