T - #2
Open
filforopen-source wants to merge 229 commits into
Open
Conversation
Fixing test related issues Signed-off-by: Subhash Arabhi <subhashsubbu636@gmail.com>
Standalone run output correction
…5+ EA Updated the code to obtain the parent diagnostics keys for feature-related errors/warnings to be agnostic to movement across different diagnostic types in different JDKs. For example, Warning -> LinterWarning
Fixing test related issues
Updated the JavaLangFeatures feature name extractor to work with JDK25+ EA
…rect for the standalone projects
1. For gradle projects, the CompilerOptionsQuery provides the required compiler arguments for a Source file/folder, not the project root. Thus, fixed the public LspServerTelemetryManager.isPreviewEnabled() methods to query the source roots of the current gradle project and sub-projects in order to check for the existence of the enable-preview compiler argument. 2. Fixed LspServerTelemetryManger.getProjectType() to return "gradle" only when the project name contains "gradle". For other kinds of netbeans projects, not maven/gradle, the returned value is null. This avoids wrong metrics collected for unsupported project types, such as ant, openjdk, make etc.
…review-and-type Fixed nb-telemetry isPreviewEnabled for gradle projects
Overriding transitive dep brace-expansion version to 2.0.2.
1. Allowed LspJavaPlatformProviderOverride to initialize the override
based on the value set for the option "netbeans.lsp.java.platform.override"
passed as a JVM system property.
2. Utilised platform override system property in Java VSCode extension
1. From the Java VSCode extension, passed the value of
"jdk.project.jdkhome" configuration to the NBLS via the JVM
system property flag "netbeans.lsp.java.platform.override".
2. This additionally allows the LspJavaPlatformProviderOverride to initialize
the JavaPlatform override during construction, avoiding any caching
of the default platform prior to the configuration being read via LSP.
Fixed enable preview event field value for Gradle and Standalone projects
…ava_platform_override_init Constructor init of java.lsp.server JavaPlatformProvider override
changelog for 24.1.1
Merge 'oracle:main' as on 2025-08-26 See merge request oci-jpg-jvsce/javavscode-cpu!3
Applying version recommendation
Corrected the init of the test folder structure for gradle integration tests to correspond to that expected when created using `gradle init`.
1. Updated netbeans submodule to tag:27 i.e. branch:release270 HEAD. 2. Removed patches already merged in NB26 and NB27. 3. Fixed whitespace warnings in remaining patches 4. Updated third-party licenses text 5. Incorporated inline-hints support with the jdk.inlay.hints configuration.
Update to NetBeans 27
…hutdown handlers for LSP server.
Updated README known issues
Sync 24.1.1 20250909
updating jdk25 , updated changelog
Sync changes for 24.1.1 on 20250917
Updated downloader constant for openjdk base url from 26 to 26.0.1
Updated sbom generation tools patch versions
Updated README with the known issue regarding disable nb-javac setting
Hide this using a deprecationMessage since it is currently unsupported for JDK 26 and early-access versions of JDK 27 and higher.
- Removed translated messages from netbeans-l10n which are no longer present in netbeans or patches. - Added new nbcode notebook module translations from 25.0.1 - Added/removed empty lines at the end of files or under the license header.
Added ja and zh-cn translations of new messages added for v26.0.0. Also includes minor cleanup in sort order of a few keys and extra newlines at the end of the file.
…c-setting Temporarily hide the jdk.advanced.disable.nbjavac setting
l10n updates for v26.0.0
- Fixed merge issue in README causing reordering of the Maven user settings and VS Code variable substitution sections. - Added a note about working around VS Code variable substitution in settings when using literal string that looks like a variable reference. - Commented out shields badges for VS Code Marketplace that have been retired (Refer: vscodemarketplace issue 1776). - Added Changelog entries for new static content changes in v26.0.0
- Pinned earlier version of cdxgen for which transitive dependency versions are not failing. - Moved installation of cyclonedx and other sbom generation tools before the step of building netbeans, to detect failures earlier. - Remove hardcoded node path
Fixed SBOM generation failure on older node versions
Amended README and Changelog for v26.0.0 features
Sync 26.0.1 from main
New setting ID typo fix: jdk.format.settings -> jdk.format.options
…depMsg Fixed the new ID in the deprecationMessage for jdk.format.settingsPath
Incorporated the contribution policy for generative AI from product management. Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
LSP server - Package creation and detect duplicate class file name
Update CONTRIBUTING.md
Fixed handler.ts:jdkHomeValueHandler() to have the promise return the fallback env vars JDK_HOME or JAVA_HOME when no config value is defined. - The config getter returns the default value i.e. null, in such a case. - Thus, the defaultValue parameter cannot be used, since the vscode config getter returns the default value defined in package.json, causing the value to not be `undefined`. - So, a `then()` clause on the promise is needed to check for `null` or `undefined` value, and fallback to the env vars, if so.
…-handler-fallback Fixed jdkHome config value handler fallback to env vars
Backports netbeans PR 9369. - Added checks for null and required JsonElement type in the registered config change listeners in WorkspaceService. - Included a check for blank input defaultPlatformOverride in AbstractJavaPlatformProviderOverride to avoid expensive initialization in such cases. This fixes issues like "IOException: Invalid J2SE platform" when `jdk.project.jdkhome` is set to `""` in settings.json.
…ers-null-check Added basic type checks in java.lsp.server config change listeners
Merge changes from branch 26.0.1 to main
This workflow triggers Datadog Synthetic tests on push and pull request events to the main branch. It includes steps for using Datadog's GitHub action with necessary API and application keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.