-
Notifications
You must be signed in to change notification settings - Fork 0
fix(RS1038): bump ANcpLua.Roslyn.Utilities to 1.31.0 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Roslyn.Utilities 1.31.0 removes Microsoft.CodeAnalysis.Workspaces.Common from the core package (CodeFixProviderBase moved to Testing). This eliminates the transitive Workspaces dependency that caused 169 RS1038 errors in analyzer projects. No workarounds needed — clean version bump resolves the issue at source. Upstream: ANcpLua/ANcpLua.Roslyn.Utilities#29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @ANcpLua, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical build issue by updating two key utility package versions, Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughVersion properties for two Roslyn utilities packages were incremented from 1.30.2 to 1.31.0 in the Version.props configuration file. The updates affect the runtime and testing packages. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly bumps the versions of ANcpLua.Roslyn.Utilities and ANcpLua.Roslyn.Utilities.Testing to 1.31.0 to resolve an issue with transitive dependencies. The change is straightforward and well-described. I've added one suggestion to improve the maintainability of the version properties file by linking the two related package versions, which should prevent them from diverging in the future.
| ═══════════════════════════════════════════════════════════════════════ --> | ||
| <PropertyGroup Label="Roslyn.Utilities.Testing"> | ||
| <ANcpLuaRoslynUtilitiesTestingVersion>1.30.2</ANcpLuaRoslynUtilitiesTestingVersion> | ||
| <ANcpLuaRoslynUtilitiesTestingVersion>1.31.0</ANcpLuaRoslynUtilitiesTestingVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and ensure these two package versions stay in sync, consider referencing the ANcpLuaRoslynUtilitiesVersion property here. Since ANcpLua.Roslyn.Utilities and ANcpLua.Roslyn.Utilities.Testing appear to be versioned together, this would prevent them from accidentally diverging in the future.
<ANcpLuaRoslynUtilitiesTestingVersion>$(ANcpLuaRoslynUtilitiesVersion)</ANcpLuaRoslynUtilitiesTestingVersion>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates centralized package version pins to consume ANcpLua.Roslyn.Utilities v1.31.0, which (per upstream) removes the Microsoft.CodeAnalysis.Workspaces.* dependency from the core runtime package and resolves RS1038 analyzer build failures caused by transitive dependency leakage under central transitive pinning.
Changes:
- Bump
ANcpLua.Roslyn.Utilitiesfrom1.30.2→1.31.0 - Bump
ANcpLua.Roslyn.Utilities.Testingfrom1.30.2→1.31.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
ANcpLua.Roslyn.UtilitiesandANcpLua.Roslyn.Utilities.Testingfrom 1.30.2 to 1.31.0Microsoft.CodeAnalysis.Workspacesleaking into analyzer assembliesRoot Cause
The core
ANcpLua.Roslyn.Utilitiespackage had a transitive dependency onMicrosoft.CodeAnalysis.Workspaces.Common(viaCodeFixProviderBase). Combined with CPM transitive pinning, this pulled Workspaces into analyzer projects that referenceANcpLua.Roslyn.Utilities.Fix
Upstream fix in ANcpLua.Roslyn.Utilities PR #29: moved
CodeFixProviderBaseandSyntaxModifierExtensionsfrom core to the Testing package, removing the Workspaces dependency from core.This PR simply bumps Version.props to consume the fixed version.
Changes
Version.props:ANcpLuaRoslynUtilitiesVersion1.30.2 → 1.31.0Version.props:ANcpLuaRoslynUtilitiesTestingVersion1.30.2 → 1.31.0Verification
🤖 Generated with Claude Code
Summary by CodeRabbit