Skip to content

Conversation

@ANcpLua
Copy link
Owner

@ANcpLua ANcpLua commented Feb 7, 2026

Summary

  • Bumps ANcpLua.Roslyn.Utilities and ANcpLua.Roslyn.Utilities.Testing from 1.30.2 to 1.31.0
  • Fixes 169 RS1038 CI failures caused by Microsoft.CodeAnalysis.Workspaces leaking into analyzer assemblies

Root Cause

The core ANcpLua.Roslyn.Utilities package had a transitive dependency on Microsoft.CodeAnalysis.Workspaces.Common (via CodeFixProviderBase). Combined with CPM transitive pinning, this pulled Workspaces into analyzer projects that reference ANcpLua.Roslyn.Utilities.

Fix

Upstream fix in ANcpLua.Roslyn.Utilities PR #29: moved CodeFixProviderBase and SyntaxModifierExtensions from core to the Testing package, removing the Workspaces dependency from core.

This PR simply bumps Version.props to consume the fixed version.

Changes

  • Version.props: ANcpLuaRoslynUtilitiesVersion 1.30.2 → 1.31.0
  • Version.props: ANcpLuaRoslynUtilitiesTestingVersion 1.30.2 → 1.31.0

Verification

  • Build and run the analyzer verification suite to confirm RS1038 is resolved

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated Roslyn Utilities and Roslyn Utilities Testing packages to version 1.31.0.

Roslyn.Utilities 1.31.0 removes Microsoft.CodeAnalysis.Workspaces.Common
from the core package (CodeFixProviderBase moved to Testing). This
eliminates the transitive Workspaces dependency that caused 169 RS1038
errors in analyzer projects.

No workarounds needed — clean version bump resolves the issue at source.

Upstream: ANcpLua/ANcpLua.Roslyn.Utilities#29

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 7, 2026 20:29
@gemini-code-assist
Copy link

Summary of Changes

Hello @ANcpLua, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical build issue by updating two key utility package versions, ANcpLua.Roslyn.Utilities and ANcpLua.Roslyn.Utilities.Testing. The update consumes an upstream fix that refactored dependencies, preventing Microsoft.CodeAnalysis.Workspaces from being inadvertently included in analyzer projects. This resolves numerous CI failures and stabilizes the build process by ensuring correct dependency isolation.

Highlights

  • Dependency Version Bump: The versions of ANcpLua.Roslyn.Utilities and ANcpLua.Roslyn.Utilities.Testing have been updated from 1.30.2 to 1.31.0.
  • CI Failure Resolution: This update resolves 169 RS1038 CI failures that were occurring due to Microsoft.CodeAnalysis.Workspaces leaking into analyzer assemblies.
  • Root Cause Fix: The core issue stemmed from ANcpLua.Roslyn.Utilities having a transitive dependency on Microsoft.CodeAnalysis.Workspaces.Common, which was resolved by an upstream fix that moved CodeFixProviderBase and SyntaxModifierExtensions to the Testing package, thereby removing the Workspaces dependency from the core utility package.
Changelog
  • Version.props
    • Updated ANcpLuaRoslynUtilitiesVersion from 1.30.2 to 1.31.0.
    • Updated ANcpLuaRoslynUtilitiesTestingVersion from 1.30.2 to 1.31.0.
Activity
  • The pull request was authored by ANcpLua.
  • The changes involve updating version numbers within the Version.props file.
  • The PR description provides a detailed summary, root cause analysis, and verification steps for the fix.
  • The pull request was generated using 'Claude Code'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Feb 7, 2026

Walkthrough

Version properties for two Roslyn utilities packages were incremented from 1.30.2 to 1.31.0 in the Version.props configuration file. The updates affect the runtime and testing packages.

Changes

Cohort / File(s) Summary
Version Properties Update
Version.props
Updated ANcpLuaRoslynUtilitiesVersion and ANcpLuaRoslynUtilitiesTestingVersion from 1.30.2 to 1.31.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: bumping ANcpLua.Roslyn.Utilities to version 1.31.0, which is the primary purpose of this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/bump-roslyn-utilities-1.31.0

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly bumps the versions of ANcpLua.Roslyn.Utilities and ANcpLua.Roslyn.Utilities.Testing to 1.31.0 to resolve an issue with transitive dependencies. The change is straightforward and well-described. I've added one suggestion to improve the maintainability of the version properties file by linking the two related package versions, which should prevent them from diverging in the future.

═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities.Testing">
<ANcpLuaRoslynUtilitiesTestingVersion>1.30.2</ANcpLuaRoslynUtilitiesTestingVersion>
<ANcpLuaRoslynUtilitiesTestingVersion>1.31.0</ANcpLuaRoslynUtilitiesTestingVersion>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and ensure these two package versions stay in sync, consider referencing the ANcpLuaRoslynUtilitiesVersion property here. Since ANcpLua.Roslyn.Utilities and ANcpLua.Roslyn.Utilities.Testing appear to be versioned together, this would prevent them from accidentally diverging in the future.

    <ANcpLuaRoslynUtilitiesTestingVersion>$(ANcpLuaRoslynUtilitiesVersion)</ANcpLuaRoslynUtilitiesTestingVersion>

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates centralized package version pins to consume ANcpLua.Roslyn.Utilities v1.31.0, which (per upstream) removes the Microsoft.CodeAnalysis.Workspaces.* dependency from the core runtime package and resolves RS1038 analyzer build failures caused by transitive dependency leakage under central transitive pinning.

Changes:

  • Bump ANcpLua.Roslyn.Utilities from 1.30.21.31.0
  • Bump ANcpLua.Roslyn.Utilities.Testing from 1.30.21.31.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ANcpLua ANcpLua merged commit 6aefaf8 into main Feb 7, 2026
20 checks passed
@ANcpLua ANcpLua deleted the fix/bump-roslyn-utilities-1.31.0 branch February 7, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant