This repository was archived by the owner on Jun 14, 2023. It is now read-only.
[BUGFIX] Reverse merging order for TypoScript configuration#4
Open
IchHabRecht wants to merge 1 commit intoAOEpeople:masterfrom
Open
[BUGFIX] Reverse merging order for TypoScript configuration#4IchHabRecht wants to merge 1 commit intoAOEpeople:masterfrom
IchHabRecht wants to merge 1 commit intoAOEpeople:masterfrom
Conversation
You have an error in your merging order. The configuration from TypoScript has to overrule the one from ContentObjectRenderer as otherwise your parameter loops to its own.
|
Hey @IchHabRecht, thank you for this patch! I think it also relates to this forge issue: https://forge.typo3.org/issues/26780. |
einarsvan
pushed a commit
to Bolius/linkhandler
that referenced
this pull request
Sep 23, 2014
When interpreting link-type fields in extensions, linkhandler enters an endless loop. Some TS configuration must be unset, but this is not done thoroughly enough. See http://forge.typo3.org/issues/26780 Fixes AOEpeople#4
|
+1, same issue here. Either change the merge order or probably better remove the parameter configuration (instead of parameter**.** with dot) |
|
After giving this some more thought I think this PR is the wrong approach. Of course the local/current link's more specific configuration should overrule the global configuration. So the fix would rather be to adjust the unset() call before the merge. The if should check for parameter without appended dot and then remove both key with and without dot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You have an error in your merging order. The configuration from
TypoScript has to overrule the one from ContentObjectRenderer as
otherwise your parameter loops to its own.