Skip to content

Use std::array for pixel buffers in avifrgbtest #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wantehchang merged 1 commit into from
May 22, 2026
+14 −13
Merged

Use std::array for pixel buffers in avifrgbtest #3219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions tests/gtest/avifrgbtest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright 2023 Google LLC
// SPDX-License-Identifier: BSD-2-Clause

#include <array>
#include <tuple>

#include "avif/internal.h"
Expand Down Expand Up @@ -40,18 +41,18 @@ TEST_P(SetGetRGBATest, SetGetTest) {
epsilon = 0.0005f; // Half precision floats are not that precise.
}

float pixel_read[4];
std::array<float, 4> pixel_read;
for (uint32_t j = 0; j < rgb.height; ++j) {
for (uint32_t i = 0; i < rgb.width; ++i) {
// Generate some arbitrary pixel values.
const float pixel_to_write[4] = {
const std::array<float, 4> pixel_to_write = {
0.0f + static_cast<float>(i) / rgb.width,
0.5f + static_cast<float>(j) / (rgb.height * 2),
1.0f - static_cast<float>(i + j) / ((rgb.width + rgb.height) * 2),
1.0f - static_cast<float>(i) / rgb.width};

avifSetRGBAPixel(&rgb, i, j, &color_space, pixel_to_write);
avifGetRGBAPixel(&rgb, i, j, &color_space, pixel_read);
avifSetRGBAPixel(&rgb, i, j, &color_space, pixel_to_write.data());
avifGetRGBAPixel(&rgb, i, j, &color_space, pixel_read.data());
EXPECT_NEAR(pixel_read[0], pixel_to_write[0], epsilon);
EXPECT_NEAR(pixel_read[1], pixel_to_write[1], epsilon);
EXPECT_NEAR(pixel_read[2], pixel_to_write[2], epsilon);
Expand All @@ -64,17 +65,17 @@ TEST_P(SetGetRGBATest, SetGetTest) {
}

// Check that 0 maps to 0 and 1.0f maps to 1.0f.
const float pixel_zero[4] = {0.0f, 0.0f, 0.0f, 1.0f};
avifSetRGBAPixel(&rgb, 0, 0, &color_space, pixel_zero);
avifGetRGBAPixel(&rgb, 0, 0, &color_space, pixel_read);
const std::array<float, 4> pixel_zero = {0.0f, 0.0f, 0.0f, 1.0f};
avifSetRGBAPixel(&rgb, 0, 0, &color_space, pixel_zero.data());
avifGetRGBAPixel(&rgb, 0, 0, &color_space, pixel_read.data());
EXPECT_EQ(pixel_read[0], pixel_zero[0]);
EXPECT_EQ(pixel_read[1], pixel_zero[1]);
EXPECT_EQ(pixel_read[2], pixel_zero[2]);
EXPECT_EQ(pixel_read[3], pixel_zero[3]);

const float pixel_one[4] = {1.0f, 1.0f, 1.0f, 1.0f};
avifSetRGBAPixel(&rgb, 0, 0, &color_space, pixel_one);
avifGetRGBAPixel(&rgb, 0, 0, &color_space, pixel_read);
const std::array<float, 4> pixel_one = {1.0f, 1.0f, 1.0f, 1.0f};
avifSetRGBAPixel(&rgb, 0, 0, &color_space, pixel_one.data());
avifGetRGBAPixel(&rgb, 0, 0, &color_space, pixel_read.data());
EXPECT_EQ(pixel_read[0], pixel_one[0]);
EXPECT_EQ(pixel_read[1], pixel_one[1]);
EXPECT_EQ(pixel_read[2], pixel_one[2]);
Expand Down Expand Up @@ -103,9 +104,9 @@ TEST_P(SetGetRGBATest, GradientTest) {

for (uint32_t j = 0; j < input_rgb.height; ++j) {
for (uint32_t i = 0; i < input_rgb.width; ++i) {
float pixel[4];
avifGetRGBAPixel(&input_rgb, i, j, &color_space, pixel);
avifSetRGBAPixel(&output_rgb, i, j, &color_space, pixel);
std::array<float, 4> pixel;
avifGetRGBAPixel(&input_rgb, i, j, &color_space, pixel.data());
avifSetRGBAPixel(&output_rgb, i, j, &color_space, pixel.data());
}
}
EXPECT_TRUE(testutil::AreImagesEqual(input_rgb, output_rgb));
Expand Down
Loading