oac_demo: add -wav option to write WAV output#8
Closed
akashtc wants to merge 5 commits into
Closed
Conversation
jmvalin
reviewed
Jan 30, 2026
|
|
||
| #include "oac_types.h" | ||
|
|
||
| #endif /* OPUS_TYPES_H */ |
Contributor
There was a problem hiding this comment.
These changes (opus_types.h) should no longer be needed once PR1 is merged.
jmvalin
reviewed
Jan 30, 2026
| - If a test fails locally, run `make clean` and rebuild before investigating. | ||
| - Some tests require a POSIX-like environment (e.g., Linux or macOS). | ||
|
|
||
| If you have questions, open an issue or discuss on the PR. |
Contributor
There was a problem hiding this comment.
This is a separate change and does not belong to this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add -wav option to
oac_demoso decoded output may be written as a standard WAV file. Writes a placeholder header at start and updates sizes on close. Update README and add tests that verify WAV header and data length.