Skip to content

wip: fix MSVC CI by adding opus_types shim#9

Closed
akashtc wants to merge 14 commits into
mainfrom
wip/fix-msvc-ci
Closed

wip: fix MSVC CI by adding opus_types shim#9
akashtc wants to merge 14 commits into
mainfrom
wip/fix-msvc-ci

Conversation

@akashtc
Copy link
Copy Markdown

@akashtc akashtc commented Jan 30, 2026

This is a WIP/draft patch that adds a compatibility shim include/opus_types.h and registers it in CMake/Makefile to address Windows MSVC CI failures where generated DNN headers expect opus_types.h. Please re-run CI to see if the errors are resolved; I'll follow up with more MSVC-specific fixes if needed.

Copy link
Copy Markdown
Author

akashtc commented Jan 30, 2026

Fixes included in this update:\n- tests: add missing 'tests/test_oac_demo_wav.c' (fixes AutoTools make error)\n- ci: add Clang ASAN/UBSAN workflow to catch memory/UB issues\n- fix: remove unused WAV variable in 'src/oac_demo.c'\n\nI've pushed these commits to 'wip/fix-msvc-ci' (updated branch). Please re-run CI (or it will trigger automatically). If Windows/MSVC failures persist, I can investigate the DNN data header syntax errors next.

Copy link
Copy Markdown
Author

akashtc commented Jan 30, 2026

Temporary workaround: disable building DNN/DRED/OSCE on MSVC (cl) to avoid numerous compile errors in generated DNN sources. This is a short-term mitigation so Windows MSVC CI can turn green while we investigate making the generated dnn/* sources MSVC-friendly (fix typedefs, constant initializers, or generator). Will follow up with generator fixes and/or more targeted shims. CI updated and branch pushed: wip/fix-msvc-ci

@jmvalin
Copy link
Copy Markdown
Contributor

jmvalin commented Jan 30, 2026

Is there anything in there that still applies after PR1 is merged?

@akashtc akashtc closed this Feb 5, 2026
@akashtc akashtc deleted the wip/fix-msvc-ci branch February 5, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants