Improve Marathi translations for natural language and clarity#691
Improve Marathi translations for natural language and clarity#691kumbharkajal wants to merge 16 commits intoAOSSIE-Org:devfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR adds Marathi locale support and updates Marathi translations: adds Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.Add a .trivyignore file to your project to customize which findings Trivy reports. |
|
🎉 Welcome @kumbharkajal!
We appreciate your contribution! 🚀 |
|
The UTF-8 decoding error is fixed by re-saving app_mr.arb as plain UTF-8. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @lib/l10n/app_mr.arb:
- Line 47: Replace the systematic misspelling "आपणण" with the correct Marathi
"आपण" throughout the ARB file; update every affected localization value (e.g.,
the keys "youNoStories", "youNoLikedStories", "you", "areYouSure", "loggingOut"
and all other occurrences listed in the review) by performing a global
search-and-replace for "आपणण" → "आपण" so all message strings are corrected
consistently.
- Line 39: The Marathi localization contains a systematic typo where "आपणल्या"
and "आपणले" are used instead of the correct possessive "आपल्या"; update all
affected message values to use "आपल्या" (or the correct contextual possessive) —
e.g., replace "आपणल्या" → "आपल्या" and "आपणले" → "आपल्या" in the entries such as
"yourStories", "yourLikedStories", "emailChangeInfo", and
"oauthUsersEmailChangeInfo" and perform a file-wide search for other instances
(lines noted in the review) to apply the same fix consistently.
🧹 Nitpick comments (1)
lib/l10n/app_mr.arb (1)
293-293: Consider: Consistency in "add" vs "join" translationsThe phrase "सामील व्हा" (join/become part of) is used for multiple "add" actions:
- Line 293: "addModerator" → "मॉडरेटर सामील व्हा"
- Line 297: "addSpeaker" → "स्पीकर सामील व्हा"
- Line 1113: "addChapter" → "अध्याय सामील व्हा"
- Line 1485: "addFriend" → "मित्र सामील व्हा"
While "सामील व्हा" works conversationally, you might want to consider using "जोडा" (add) for actions where the user is adding something (like chapters) versus joining something (like communities at line 605 where "सामील व्हा" is more appropriate).
However, if the current phrasing aligns with natural Marathi usage in your target audience, this is acceptable.
Also applies to: 297-297, 605-605, 1113-1113, 1485-1485
|
did you run flutter gen-l10n along with the PR? Are you a native Marathi speaker? |
|
Yes, I ran flutter gen-l10n locally. I am a native Marathi speaker, which is how I identified the inaccuracies and improved the translations for correctness, clarity, and natural usage. I’m happy to make further refinements if needed. |
|
You marked this as related to #688 but that deals with missing translations and this isn't adding any missing translation. Please open an issue to go along with your PR, and change the base branch of the PR to dev. Additionally, follow the PR template strictly in the future |
|
Sorry for the confusion. I mistakenly referenced #688 instead of #488. |
| "description": "दुसऱ्या वापरकर्त्याचा प्रोफाइल पाहताना संदेश दिसतो जर त्यांच्याकडे कोणतीही कथा नाही." | ||
| }, | ||
| "youNoStories": "आपणण कोणतीही कथा निर्मित केली नाही", | ||
| "youNoStories": "आपण कोणतीही कथा निर्मित केली नाही", |
There was a problem hiding this comment.
same thing happened here as well
There was a problem hiding this comment.
Yes because 'आपणण' is not a word at all and you is written as 'आपण'
There was a problem hiding this comment.
I think you are not a native marathi speaker, because there were many mistakes and hindi words. That's not how marathi is supposed to be.
There was a problem hiding this comment.
'आपणण' ik that but you didnt changed the char at all
if u compare आपण both are same in my file and your change thats what i meant
There was a problem hiding this comment.
I think you are not a native marathi speaker, because there were many mistakes and hindi words. That's not how marathi is supposed to be.
its fine u prolly thinking i might have changed something locally but you will believe the files that are already in the master repo
what i am saying is i dont think i added the word आपणण this in my file
There was a problem hiding this comment.
i made many wrong strings correct so may be something happened by my side related to you and your only. but i'm sure except this there's no other conflict with your file
There was a problem hiding this comment.
sorry what you mean by that
changes i did are visible we got conflict related to you your only
There was a problem hiding this comment.
@kumbharkajal i also might have made some mistakes while writting i wasnt targeting you there were some strings that was unchanged thats why i mentioned i am sorry yes others were right
There was a problem hiding this comment.
yes few mistakes related to you your are possible because i changed them all together so
There was a problem hiding this comment.
See those changes you are mentioning are not visible from my side
|
@kumbharkajal also after making the change arent you supposed to add this file app_localizations_mr.dart as well ik after running the command (flutter gen-l10n) it like changes that file automatically but still i added both files always when i used to making changes to that..... ig you should add both files too |
|
app_localizations_mr.dart is an auto-generated file created by flutter gen-l10n from the .arb files. |
yes because technically it also changed with arb right so ig you should |
sure i'll add that as well |
Yes, please commit all other generated files as well, including untranslated.txt |
sure i'll add |
I’ve regenerated localization files using flutter gen-l10n and committed all generated outputs, including app_localizations_mr.dart and untranslated.txt, as requested. |
i think you are supposed to resolve merge conflit |
yes i'm doing it |
|
@4555jan |
kumbharkajal
force-pushed
the
improve-marathi-translations
branch
from
0a81fca to
569a791
Compare
|
Hi, I’ve resolved all conflicts, synced with the latest dev, and updated the Marathi translations along with regenerated l10n files. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@lib/l10n/app_localizations_mr.dart`:
- Around line 180-182: The localized string getter oauthUsersEmailChangeInfo in
lib/l10n/app_localizations_mr.dart contains a missing space in
"आपणGoogle/GitHub"; fix the source ARB (app_mr.arb) by inserting a space so it
reads "आपण Google/GitHub" and then regenerate the localization files so the
corrected text is propagated into the oauthUsersEmailChangeInfo getter (and any
other affected locale files).
- Around line 69-72: The getter userNoLikedStories is missing the `@override`
annotation (it overrides the parent localization getter) causing a lint; add the
`@override` annotation above the userNoLikedStories getter to match surrounding
getters (e.g., userLikedStories, yourLikedStories, youNoLikedStories) or, since
this file is auto-generated, regenerate the localization files using flutter
gen-l10n so the `@override` is applied to userNoLikedStories automatically.
In `@lib/l10n/app_mr.arb`:
- Line 221: The translation string for the key "oauthUsersEmailChangeInfo" has a
missing space between "आपण" and "Google/GitHub"; update the value of
oauthUsersEmailChangeInfo to insert a space so it reads "आपण Google/GitHub"
(ensuring the rest of the sentence and escaping/quoting remain unchanged).
🧹 Nitpick comments (4)
lib/l10n/app_mr.arb (2)
590-594: Inconsistent JSON indentation.The
@createNewRoommetadata block has inconsistent indentation compared to other entries in the file. While this doesn't break functionality, consistent formatting improves maintainability.🔧 Suggested fix
"createNewRoom": "नवीन कक्ष तयार करा", -"@createNewRoom": { - "description": "नवीन ऑडियो कक्ष तयार करण्यासाठी बटण मजकूर किंवा पृष्ठ शीर्षक." -}, - + "@createNewRoom": { + "description": "नवीन ऑडियो कक्ष तयार करण्यासाठी बटण मजकूर किंवा पृष्ठ शीर्षक." + }, "pleaseEnterScheduledDateTime": "कृपया शेड्यूल केलेली तारीख-वेळ प्रविष्ट करा",
877-882: Inconsistent JSON indentation in connectionError block.Similar to the
@createNewRoomblock, this section has inconsistent indentation.🔧 Suggested fix
"otpResentMessage": "कृपया आपल्या मेलमध्ये नवीन ओटीपी तपासा.", - - "connectionError": "कनेक्शन त्रुटी आली आहे. कृपया आपले इंटरनेट तपासा आणि पुन्हा प्रयत्न करा.", -"@connectionError": { - "description": "नेटवर्क कनेक्शन समस्यांसाठी सामान्य त्रुटी संदेश." -}, - + "connectionError": "कनेक्शन त्रुटी आली आहे. कृपया आपले इंटरनेट तपासा आणि पुन्हा प्रयत्न करा.", + "@connectionError": { + "description": "नेटवर्क कनेक्शन समस्यांसाठी सामान्य त्रुटी संदेश." + }, "seconds": "सेकंद.",lib/l10n/app_localizations_mr.dart (2)
81-88: Inconsistent formatting in generated code.The closing brace formatting in
noAvailableRoom(line 86:});) differs from the standard Flutter gen-l10n output pattern. This inconsistency appears in multiple methods throughout the file (e.g., lines 612, 958, 963).Since this is an auto-generated file, avoid manual edits. Regenerate using
flutter gen-l10nto ensure consistent formatting.
398-408: Untranslated strings remain in English.Several strings in this section remain untranslated:
hide→ "Remove"removeRoom→ "Remove Room"removeRoomFromList→ "Remove from list"removeRoomConfirmation→ "Are you sure you want to remove..."While this PR focuses on improving existing translations, these should be translated for consistency.
Would you like me to help translate these remaining English strings to Marathi?
|
@M4dhav there are few untranslated strings of marathi can i create a new issue and pull request for the same? |
|
@M4dhav i added those deleted strings and untranslated strings as well in this PR please review it |
kumbharkajal
force-pushed
the
improve-marathi-translations
branch
from
53195e3 to
0f35dd0
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@lib/l10n/app_localizations_mr.dart`:
- Around line 64-73: Update the Marathi localization so the yourLikedStories
getter uses plural phrasing to match userLikedStories: change the string for
yourLikedStories from 'आपल्या आवडीची कथा' to 'आपल्या आवडलेल्या कथा' in the
app_mr.arb localization source, then run the localization regeneration tool to
update app_localizations (ensure the getter yourLikedStories in
lib/l10n/app_localizations_mr.dart is regenerated to reflect the new string and
remain consistent with userLikedStories).
- Around line 236-245: The Marathi strings for addModerator and addSpeaker use
"सामील व्हा" (join) but should use "जोडा" (add) to reflect granting privileges;
update the Marathi resource (app_mr.arb) entries corresponding to the getters
addModerator and addSpeaker to use "जोडा" instead of "सामील व्हा", then
regenerate the Dart localization file so the getters addModerator and addSpeaker
in lib/l10n/app_localizations_mr.dart are rebuilt with the corrected wording
(ensure makeModerator()/makeSpeaker() context is preserved).
|
@M4dhav i have added all untranslated strings please review the file. |
3 participants
What this PR does
This PR improves the Marathi translations in
lib/l10n/app_mr.arbto make themmore natural, fluent, and linguistically correct.
Changes include:
✔ Replacing literal or Hindi-influenced text with proper Marathi phrasing
✔ Improving clarity and consistency of UI labels and messages
✔ Fixing grammar issues where necessary
✔ Keeping all existing keys unchanged (only localization content)
How I Verified
flutter gen-l10nlocally — no errorsWhy this is useful
Improved Marathi translations enhance the user experience for Marathi
speakers and help the app feel more natural and localized.
Issue
Fixes #704
Summary by CodeRabbit
Localization
Chores