Skip to content

Add marwari translation#731

Open
KAkhinish2108 wants to merge 2 commits intoAOSSIE-Org:devfrom
KAkhinish2108:Add-Marwari-Translation
Open

Add marwari translation#731
KAkhinish2108 wants to merge 2 commits intoAOSSIE-Org:devfrom
KAkhinish2108:Add-Marwari-Translation

Conversation

@KAkhinish2108
Copy link
Copy Markdown

Description

This PR adds initial Marwari (ISO 639-2: mwr) localization support.

Changes included:

  1. Added app_mwr.arb for Marwari translations
  2. Added app_localizations_mwr.dart
  3. Updated localization registration where required

Fixes #710


Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking CHANGE which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

As discussed earlier, Marwari uses a 3-letter ISO code and may require additional configuration. I am aware of this and ready to handle any follow-up changes suggested during review. Tested on my Computer

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes Marwari #710 (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

@KAkhinish2108 KAkhinish2108 requested a review from M4dhav as a code owner January 22, 2026 05:32
@github-actions
Copy link
Copy Markdown
Contributor

🎉 Welcome @KAkhinish2108!
Thank you for your pull request! Our team will review it soon. 🔍

  • Please ensure your PR follows the contribution guidelines. ✅
  • All automated tests should pass before merging. 🔄
  • If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KAkhinish2108
Copy link
Copy Markdown
Author

@M4dhav
This is Akhinish Chouhan,.

Everything is clear now...I hope you will merge this final PR I tried my best for removing unrelated commits but my system gets crash again and again....

Waiting for your response

@KAkhinish2108
Copy link
Copy Markdown
Author

@M4dhav

waiting for your acceptance

Copy link
Copy Markdown
Contributor

@M4dhav M4dhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR still contains unrelated commits

@KAkhinish2108
Copy link
Copy Markdown
Author

@M4dhav
but I tried my best to remove them, but vo vapis as it is hi aa raha h.. used all required git commands... talked to my mentor he himself told me that vo vapis same state m aa raha h...

@KAkhinish2108
Copy link
Copy Markdown
Author

@M4dhav

Waiting for your response sir

@KAkhinish2108
Copy link
Copy Markdown
Author

@M4dhav

Hi, I am waiting for your response I tried it today but still its showing all commits as it is...

@KAkhinish2108
Copy link
Copy Markdown
Author

@M4dhav

Hii This is Akhinish, Waiting for your response sir

@KAkhinish2108
Copy link
Copy Markdown
Author

KAkhinish2108 commented Jan 29, 2026

@M4dhav

Hii, This is Akhinish Chouhan

let us be clear with each other, I don't understand this that this PR is purely clean like there were 2 conflicts but resolved them... may I know what's the problem right now in this PR and if there is a problem then what is a solution for it...

Trust me @M4dhav I was new to this tech field and open-source, never heard about gitHub before joining my college but since 2-3 months after my 1sem got over I am trying my best sir.... I apologize for all that failed PRs...

waiting for your response @M4dhav

@KAkhinish2108
Copy link
Copy Markdown
Author

@M4dhav

Waiting for your response sir

@KAkhinish2108 KAkhinish2108 requested a review from M4dhav February 4, 2026 13:02
Copy link
Copy Markdown
Contributor

@M4dhav M4dhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KAkhinish2108 , sorry about my absence over the past few weeks, I have been busy in other things for some time.

To answer your question, This PR contains commits unrelated to the scope of the PR, due to unrelated histories. This is probably happening because you used master as your base branch when contributing and then opened the PR to dev. While ideally this should not cause issues because dev follows master's history, in this case there were differing histories which is causing this issue.

To fix this, you have two main options:

  1. Rebase your branch with upstream/dev
  2. Create a new branch based off upstream/dev and cherry-pick your changes onto that branch, and then open a PR from that new branch.

@KAkhinish2108
Copy link
Copy Markdown
Author

@M4dhav

Sure, let me see which option takes less time and I know both the options are maybe bit of frustrating for me but I will do my best for either one of the suggested option..

btw, Thanks for responding here..

@KAkhinish2108
Copy link
Copy Markdown
Author

@M4dhav

btw there is one spelling mistake in Resonate README.md instead favourite its "favourate" and I just want to enhance README.md as you know README.md is the first impression, where it contains everything, about the project, steps for contributing, etc.. it will be great if you could allow me to just enhance that..?

@KAkhinish2108 KAkhinish2108 force-pushed the Add-Marwari-Translation branch from fa2539d to 6713bc0 Compare February 9, 2026 17:06
@KAkhinish2108
Copy link
Copy Markdown
Author

@M4dhav

it's ready for review, kindly merge it...

@M4dhav
Copy link
Copy Markdown
Contributor

M4dhav commented Feb 11, 2026

@M4dhav

btw there is one spelling mistake in Resonate README.md instead favourite its "favourate" and I just want to enhance README.md as you know README.md is the first impression, where it contains everything, about the project, steps for contributing, etc.. it will be great if you could allow me to just enhance that..?

check if the issue exists on dev and then handle accordingly

@M4dhav M4dhav linked an issue Feb 11, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@M4dhav M4dhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For adding 3 Letter codes, you need to also add a custom locale, check #605 for reference

@KAkhinish2108
Copy link
Copy Markdown
Author

KAkhinish2108 commented Feb 15, 2026

@M4dhav

Sure I will work on it, But I already Created a custom locale for marwari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marwari

2 participants