Add marwari translation#731
Conversation
|
🎉 Welcome @KAkhinish2108!
We appreciate your contribution! 🚀 |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@M4dhav Everything is clear now...I hope you will merge this final PR I tried my best for removing unrelated commits but my system gets crash again and again.... Waiting for your response |
|
waiting for your acceptance |
M4dhav
left a comment
There was a problem hiding this comment.
PR still contains unrelated commits
|
@M4dhav |
|
Waiting for your response sir |
|
Hi, I am waiting for your response I tried it today but still its showing all commits as it is... |
|
Hii This is Akhinish, Waiting for your response sir |
|
Hii, This is Akhinish Chouhan let us be clear with each other, I don't understand this that this PR is purely clean like there were 2 conflicts but resolved them... may I know what's the problem right now in this PR and if there is a problem then what is a solution for it... Trust me @M4dhav I was new to this tech field and open-source, never heard about gitHub before joining my college but since 2-3 months after my 1sem got over I am trying my best sir.... I apologize for all that failed PRs... waiting for your response @M4dhav |
|
Waiting for your response sir |
M4dhav
left a comment
There was a problem hiding this comment.
Hey @KAkhinish2108 , sorry about my absence over the past few weeks, I have been busy in other things for some time.
To answer your question, This PR contains commits unrelated to the scope of the PR, due to unrelated histories. This is probably happening because you used master as your base branch when contributing and then opened the PR to dev. While ideally this should not cause issues because dev follows master's history, in this case there were differing histories which is causing this issue.
To fix this, you have two main options:
- Rebase your branch with upstream/dev
- Create a new branch based off upstream/dev and cherry-pick your changes onto that branch, and then open a PR from that new branch.
|
Sure, let me see which option takes less time and I know both the options are maybe bit of frustrating for me but I will do my best for either one of the suggested option.. btw, Thanks for responding here.. |
|
btw there is one spelling mistake in Resonate README.md instead favourite its "favourate" and I just want to enhance README.md as you know README.md is the first impression, where it contains everything, about the project, steps for contributing, etc.. it will be great if you could allow me to just enhance that..? |
fa2539d to
6713bc0
Compare
|
it's ready for review, kindly merge it... |
check if the issue exists on dev and then handle accordingly |
|
Sure I will work on it, But I already Created a custom locale for marwari |
Description
This PR adds initial Marwari (ISO 639-2: mwr) localization support.
Changes included:
Fixes #710
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
As discussed earlier, Marwari uses a 3-letter ISO code and may require additional configuration. I am aware of this and ready to handle any follow-up changes suggested during review. Tested on my Computer
Checklist:
Maintainer Checklist