Skip to content

#1 add ip_bytes to Property for raw-byte IPv4 encoding #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bibonix wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#1 add ip_bytes to Property for raw-byte IPv4 encoding #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions pong.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,11 @@ message Property {
// ISO 3166-1 alpha-2 country code of the slot ("US", "DE", …).
string country = 2;

// Public IPv4 of the Node currently backing this slot, in dotted
// form ("203.0.113.7"). Empty / "0.0.0.0" while the slot is
// detached.
// Deprecated: use ip_bytes. Public IPv4 of the Node currently
// backing this slot, in dotted form ("203.0.113.7"). Empty /
// "0.0.0.0" while the slot is detached. New consumers should
// read ip_bytes instead; this field will be reserved once all
// clients have migrated.
string ip = 4;

// TCP port to dial on the backing Node. Always 443 in production
Expand All @@ -50,6 +52,12 @@ message Property {
// Node, in which case the Hub re-attaches it to a fresh Node and
// the client receives an updated Property.
uint64 expires = 7;

// Public IPv4 of the Node currently backing this slot, as four
// raw bytes in network byte order — same encoding as Peer.ip.
// Empty (zero-length) while the slot is detached. Replaces the
// deprecated string ip field (field 4).
bytes ip_bytes = 8;
}

// Peer describes one sibling Node in the fleet, advertised to
Expand Down