refactor: drop unused sounds, input mapper, and crawler_mode - #98
Open
dakejahl wants to merge 4 commits into
Open
refactor: drop unused sounds, input mapper, and crawler_mode#98dakejahl wants to merge 4 commits into
dakejahl wants to merge 4 commits into
Conversation
Nothing in the firmware calls it. LTO already drops it from the binary; delete the source so it is not rediscovered as a live tune.
Old oneshot-style pulse mapper. Nothing calls it.
The flag was never written after init-to-zero. The crawler BEMF-timeout branch was dead; keep the live startup-duty path only.
inputSet, dshot, and servoPwm were declared twice in the same header.
dakejahl
marked this pull request as ready for review
August 15, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete a few unused functions and a dead flag. One commit each.
Problem
playDuskingTuneandcomputeMSInputhave no callers.crawler_modeis never written after init-to-zero, so its BEMF-timeout branch is dead.signal.hdeclaredinputSet/dshot/servoPwmtwice.Solution
Remove the dead code and the duplicate externs. LTO already dropped the unused functions from the binary; this just deletes the source. No behavior change.