This repository was archived by the owner on Jan 15, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 121
UiBench: Support multiple activities #1187
Open
qais-yousef
wants to merge
1
commit into
ARM-software:master
Choose a base branch
from
qais-yousef:activities
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,8 @@ class Uibench(ApkWorkload): | |
| recommend using the APK of UIBench corresponding to the | ||
| Android version, enforced through the ``version`` parameter to | ||
| this workload. | ||
| You can provide multiple activities to run by separating them | ||
| with white space. | ||
| """), | ||
| Parameter('duration', kind=int, default=10, | ||
| description=""" | ||
|
|
@@ -47,6 +49,27 @@ class Uibench(ApkWorkload): | |
| """), | ||
| ] | ||
|
|
||
| def run(self, context): | ||
| super(Uibench, self).run(context) | ||
| self.target.sleep(self.duration) | ||
| def __init__(self, target, **kwargs): | ||
| super(Uibench, self).__init__(target, **kwargs) | ||
| if self.activity: | ||
| activities = self.activity.split() | ||
| self.activity = '' | ||
| for activity in activities: | ||
| if '.' not in activity: | ||
| # If we're receiving just the activity name, it's taken relative to | ||
| # the package namespace: | ||
| self.activity += ' .' + activity | ||
| else: | ||
| self.activity += ' ' + activity | ||
|
|
||
| def setup(self, context): | ||
| if self.activity: | ||
| activities = self.activity.split() | ||
| for activity in activities: | ||
| self.apk._activity = activity | ||
| self.logger.info("Starting {} for {} seconds".format(activity, self.duration)) | ||
| super(Uibench, self).setup(context) | ||
| self.target.sleep(self.duration) | ||
|
Comment on lines
+69
to
+72
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. By launching the activities here does this form the main part of the workload? In which case we'll want to do the in the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It has always been like this. But the difference now is that we sleep in the setup instead of run, which is your point. Let me try to follow on with your suggestion which should address this too. Thanks. |
||
| else: | ||
| super(Uibench, self).setup(context) | ||
| self.target.sleep(self.duration) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update this to rather than a space separated string use the
list_or_stringkind for this parameter? That way we will preserve the existing behavior but also allow the use of proper lists to separate the activities?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.