Fix: Prevent false positives in expertise keyword matching#21
Closed
Atharva-1512 wants to merge 2 commits intoARPAHLS:mainfrom
Closed
Fix: Prevent false positives in expertise keyword matching#21Atharva-1512 wants to merge 2 commits intoARPAHLS:mainfrom
Atharva-1512 wants to merge 2 commits intoARPAHLS:mainfrom
Conversation
Contributor
|
Hi @Atharva-1512 ! Thanks so much for taking the time to submit this PR and for looking into Issue #4. After reviewing the specific changes here, we won't be able to merge this one for a few reasons:
Because the underlying bug has already been patched in Thanks again. <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced substring matching with regex word boundary matching to avoid incorrect matches (e.g., "law" matching "flaw").
Fixes #4