Project overview usage of model form #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluegelk
requested changes
Nov 21, 2025
Collaborator
fluegelk
left a comment
fluegelk
left a comment
There was a problem hiding this comment.
Nice work! Please pull the updates from main, that should allow to CI to run on PRs. There are 5 comments that should be quick to resolve.
I feel like there are still some possibilities for improvement in the form/model interaction with where code is placed and reducing duplicate validation code, but in the interest of time I would leave that as is for now.
canvas_editor/project_management/templates/project_management/modals/updateProjectModal.html
Outdated
Show resolved
Hide resolved
canvas_editor/project_management/tests/test_views/test_project_page.py
Outdated
Show resolved
Hide resolved
canvas_editor/project_management/templates/project_management/project.html
Outdated
Show resolved
Hide resolved
…project.html Co-authored-by: fluegelk <35153980+fluegelk@users.noreply.github.com>
plhrtr
force-pushed
the
project-overview-usage-model-form
branch
2 times, most recently
from
31ba8b9 to
152f3b1
Compare
plhrtr
force-pushed
the
project-overview-usage-model-form
branch
from
152f3b1 to
8088331
Compare
|
fluegelk
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
[Secrets] are not passed to workflows that are triggered by a pull request from a fork., so manual execution for the test is needed here. (They run fine locally on my machine)This PR makes more use of the Django model form for both the project creation and updating process.
Also now the create project model shows the occurring error directly and not via the message system.
Closes #81