73 reduce code duplication in canvas objects by implementing shared functionality in canvasobject

[lisannengel]

Refactored Receiver and Heliostat by introducing a new MovableCanvasObjects class to extract shared functionality not used by LightSource.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.79%. Comparing base (0f20f22) to head (439f443).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files          60       60           
  Lines        1493     1493           
=======================================
  Hits         1475     1475           
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[plhrtr]

A general note.

I think the idea of separating the objects into different classes for each functionality is a very good idea, but in the current implementation we would have a Problem if a e.g. RotatableCanvasObject gets added.

Maybe a different pattern would be more fitting here, as there is no multiple inheritance in Js.
Something like Composition or even Mixins (We used them in the backend for stuff like the LoginRequiredMixin, but I don't now how nice something like this is implementable in Js with proper JsDocs), could work

[lisannengel]

@plhrtr fair point, I implemented it as a composition pattern now. :)

[plhrtr]

Besides renaming the class, lgtm!

[fluegelk]

Mostly looking good, just a few comments to address

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud