Skip to content

Conversation

@davidornelas11
Copy link
Contributor

@davidornelas11 davidornelas11 commented Dec 22, 2025

Add new button styles and deprecate old ones

Description

Checklist

  • Tests pass for relevant code changes

Important Reminders

Links

@davidornelas11 davidornelas11 requested a review from a team as a code owner December 22, 2025 22:04
@davidornelas11 davidornelas11 marked this pull request as draft December 22, 2025 22:04
@davidornelas11 davidornelas11 marked this pull request as ready for review December 30, 2025 17:10
@asu-jenkins-devops
Copy link
Collaborator

Copy link
Member

@mlsamuelson mlsamuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes.

As we discussed, while these changes look good, if we make the "filled" variant the default behavior, then we can skip using a separate "UDSButton" component and instead "enhance in place" the Button component, adding the new props and assuming the default (classic button) when they're not present.

This will also allow for us to avoid needing to eventually update every component that relies on the Button component in UDS, and in WS2 CKEditor we can simply add the new button variations without needing to rewrite parts of the Button plugin and include mapping logic for existing content using buttons.

@mlsamuelson
Copy link
Member

Oh, also see if the double counts on the datalayer can be addressed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants