fix: address 2 bugs from Devin Review on workspaceStore - Fix updateChildrenPaths: use startsWith+slice instead of String.replace() to prevent incorrect substring matching when renaming files/folders - Fix duplicateFile: deep-clone children with new IDs and paths when duplicating folders to avoid shared references Co-Authored-By: Thuong Huynh <admin@huynhthuong.online>#15
Open
Huynhthuongg wants to merge 6 commits into
Open
fix: address 2 bugs from Devin Review on workspaceStore
- Fix updateChildrenPaths: use startsWith+slice instead of String.replace()
to prevent incorrect substring matching when renaming files/folders
- Fix duplicateFile: deep-clone children with new IDs and paths when
duplicating folders to avoid shared references
Co-Authored-By: Thuong Huynh <admin@huynhthuong.online>#15Huynhthuongg wants to merge 6 commits into
Huynhthuongg wants to merge 6 commits into
Conversation
… project details Co-Authored-By: Thuong Huynh <admin@huynhthuong.online>
- Fix updateChildrenPaths: use startsWith+slice instead of String.replace() to prevent incorrect substring matching when renaming files/folders - Fix duplicateFile: deep-clone children with new IDs and paths when duplicating folders to avoid shared references Co-Authored-By: Thuong Huynh <admin@huynhthuong.online>
Huynhthuongg
added
bug
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fee9d7ee07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing
npm run devScreenshots
Checklist
npm run lintwith no errorsnpm run buildsuccessfully