fix: address Devin Review findings on datadog-synthetics workflow

[devin-ai-integration]

Summary

Fixes the issues identified by Devin Review on PR #4 (datadog-synthetics.yml):

1. CI failure fix: Added a step-level if condition to skip the Datadog Synthetic tests step when DD_API_KEY / DD_APP_KEY secrets are not configured. Previously, the workflow would fail with Error: Input required and not supplied: api_key when secrets weren't set up.

2. More specific test tag: Changed test_search_query from the generic tag:e2e-tests to tag:ci-required-e2e to reduce the risk of accidental CI scope changes via Datadog tag edits (as flagged by Devin Review).

3. Job rename: Renamed the job from build to e2e-tests to better reflect its purpose.

Review & Testing Checklist for Human

• Verify that the ci-required-e2e tag matches your intended Datadog Synthetic test tag (update if your tests use a different tag)
• Confirm DD_API_KEY and DD_APP_KEY are added as repository secrets when ready to run Synthetic tests
• Push a test commit to main or open a PR targeting main to verify the workflow skips gracefully when secrets are absent

Notes

• The Devin Review on PR Create datadog-synthetics.yml #4 reported "No Issues Found" (no bugs), but flagged an informational finding about the workflow relying solely on test_search_query without explicit public_id values. This PR addresses that concern by using a more specific, CI-reserved tag.
• The CI build job was failing because DD_API_KEY and DD_APP_KEY secrets were not configured in the repository.

Link to Devin session: https://app.devin.ai/sessions/b6b6ab64ba144825bc64b30c0c2a968d
Requested by: @Huynhthuongg

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[devin-ai-integration]

Devin Review found 1 potential issue.

[devin-ai-integration]

📝 Info: Secrets in step-level if condition: valid but has fork-PR implications

The added if: ${{ secrets.DD_API_KEY != '' && secrets.DD_APP_KEY != '' }} is a valid GitHub Actions pattern — the secrets context is available in step if expressions. However, note that for pull_request events triggered from forks, secrets are not passed to the workflow (they resolve to empty strings). This means the Datadog Synthetic tests step will be silently skipped for all fork PRs. This is likely the intended behavior (and arguably a security improvement), but reviewers should be aware that fork-originated PRs will never run these e2e tests, so there's no gate on external contributions.

---

Was this helpful? React with 👍 or 👎 to provide feedback.