fix: address 2 bugs from Devin Review on workspaceStore#8
Merged
Conversation
- Fix updateChildrenPaths: use startsWith+slice instead of String.replace() to prevent incorrect substring matching when renaming files/folders - Fix duplicateFile: deep-clone children with new IDs and paths when duplicating folders to avoid shared references Co-Authored-By: Thuong Huynh <admin@huynhthuong.online>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 2 bugs identified by Devin Review (PR #4) in
src/stores/workspaceStore.ts:updateChildrenPathsusesString.replace()which incorrectly matches substringschild.path.replace(oldPath, newPath)only replaces the first occurrence and can match mid-path substrings (e.g. renaming/srcwould corrupt/src2/file). Fixed by usingstartsWith()+slice()to only replace the path prefix.duplicateFiledoesn't deep-clone children when duplicating foldersSpreading
...nodecopies thechildrenarray by reference, so duplicated folders share the same child objects with identicalidandpathvalues. Added adeepCloneFileNodehelper that recursively creates new IDs and correct paths for all descendants.Review & Testing Checklist for Human
utilswhenutils-extraexists) — verifyutils-extrachildren are unaffectedNotes
Lint (
npm run lint) and typecheck (tsc -b) both pass.Link to Devin session: https://app.devin.ai/sessions/8da679d231384b9f8006427ea1372f8a
Requested by: @Huynhthuongg