FIX: Multiline support for long account labels in Ledger PDF & Page break fixes#673
Open
atm-jonathan wants to merge 2 commits into
Open
FIX: Multiline support for long account labels in Ledger PDF & Page break fixes#673atm-jonathan wants to merge 2 commits into
atm-jonathan wants to merge 2 commits into
Conversation
atm-jonathan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes layout issues in the Accountancy Ledger PDF generation:
Long Label Support: Previously, long account labels were truncated or overflowed the page margins.
Replaced the printing logic in addTitleLine to use MultiCell.
Added printTitleContentWithMulticell helper to calculate available width and wrap text automatically.
Page Break Logic: Improved page break detection in pdf_ledger.modules.php.
Added checks on $pdf->GetY() to prevent headers or subtotals from being printed at the very bottom of the page, forcing a clean page break instead.