feat: enforce single-device login on session creation - #1453
Open
github-actions[bot] wants to merge 1 commit into
Open
feat: enforce single-device login on session creation#1453github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Clear all other sessions of a user when they log in, using frappe.sessions.clear_sessions with force=True to bypass the simultaneous_sessions offset that let a second device survive under deny_multiple_sessions. Publish a realtime event after commit so connected devices learn immediately that their session was cleared. (cherry picked from commit a35536b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1452 to
version-15.Clear all other sessions of a user when they log in, using frappe.sessions.clear_sessions with force=True to bypass the simultaneous_sessions offset that let a second device survive under deny_multiple_sessions. Publish a realtime event after commit so connected devices learn immediately that their session was cleared.