feat: log out old devices instantly via realtime session check - #1457
Open
github-actions[bot] wants to merge 1 commit into
Open
feat: log out old devices instantly via realtime session check#1457github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
On hms_tz_sessions_cleared, each connected tab pings get_logged_user; tabs whose session was cleared get a 401/403 and redirect to the login page at once instead of waiting for the user's next action. The listener is registered on app_ready because frappe.realtime.on silently drops handlers added before the socket is initialized. (cherry picked from commit e391fcd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1456 to
version-15.On hms_tz_sessions_cleared, each connected tab pings get_logged_user; tabs whose session was cleared get a 401/403 and redirect to the login page at once instead of waiting for the user's next action. The listener is registered on app_ready because frappe.realtime.on silently drops handlers added before the socket is initialized.